Improving the handling of the coefficient path to avoid double slash #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminTJohnson
approved these changes
Nov 19, 2025
Contributor
BenjaminTJohnson
left a comment
BenjaminTJohnson
left a comment
There was a problem hiding this comment.
tested on two platforms ifort & gfortran
Collaborator
Author
|
@BenjaminTJohnson, thanks for checking. Were you having the same issue as @chengdang here: #256? |
Contributor
I think that issue was improperly linked files -- double slash shouldn't affect anything. |
chengdang
reviewed
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Thanks a lot Fabio!! Though the previous PR also works, so it is up to you and @BenjaminTJohnson to decide if we should merge this.
I assume there was a need from UFO or JEDI side.
Sorry about the false alarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the handling of the coefficient path to avoid a double slash.
Issue(s) addressed
Resolves #256
Dependencies
None
Impact
None
Checklist
- [ ] I have made corresponding changes to the documentation