Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented Jun 22, 2020

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the command module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

By default does JDA Utilities set the Activity no matter what.
When providing null does it still set the activity which results in no activity being set at all.

This is annoying, especially considering that this is done in the ReadyEvent and could have conflicts with bots that also set the Activity on the ReadyEvent.

This PR adds a simple check, that will JDA Utils only set the Activity when the provided activity isn't null.
This allows the usage of the Command package while still using their own method(s) to set a bots activity.

Chew pushed a commit to Chew/JDA-Chewtils that referenced this pull request Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant