Sd card reader v2 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to sd-card-reader
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
sd_card_reader/imgs/kicad-done.png
Outdated
There was a problem hiding this comment.
Is this picture with the fixed CC resistor?
There was a problem hiding this comment.
It's on the other side of the board
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
sd_card_reader/main.stanza
Outdated
| set-rules(ocdb/manufacturers/rules/jlcpcb-rules) | ||
|
|
||
| ; We want decoupling capacitors to be close to the component being decoupled | ||
| defn bypass-cap-strap (power-pin:JITXObject, gnd-pin:JITXObject, params:Tuple<KeyValue>) -> JITXObject : |
There was a problem hiding this comment.
Why do you need these functions here?
There was a problem hiding this comment.
bypass-cap-strap by default can't have parameters in it. The PR to the ocdb isn't complete yet
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
bhusang
reviewed
Jul 28, 2023
hypadr1v3
force-pushed
the
sd_card_reader_v2
branch
from
7fc6afe
to
17c3941
Compare
hypadr1v3
force-pushed
the
sd_card_reader_v2
branch
from
17c3941
to
ce3913f
Compare
bhusang
reviewed
Aug 9, 2023
| * The parameter `"_exist" => ["vendor_part_numbers.lcsc"]` allows us to specify that we require the part to have an LCSC number | ||
|
|
||
| #### USB C male connector | ||
| Our application uses USB2 so we want to use the USB2 protocol over the USB-C connection. One key aspect of the backwards compatibility is to indicate device type using resistors on the CC1, CC2 pins. In this case, we need a pull-down resistor on the CC1 pin. |
There was a problem hiding this comment.
Might want to add a link to a reference that describes the requirements for the resistors on CC1/CC2
bhusang
reviewed
Aug 9, 2023
| ## Bundles | ||
| Bundles allow us to define a set of pins which are commonly used together and allow us to view the design at a higher level. Bundles also make connecting pins easy and foolproof. For example, we can create a bundle called `sd-card-uhs-1-connector` and define every pin required for an SD card. Now we can use this to connect our controller to the SD Card connector within a single `net` statement. | ||
|
|
||
| We can create bundles within bundles too to further simplify our code. |
There was a problem hiding this comment.
Furthermore, we can create bundles within bundles to further simplify our code.
bhusang
reviewed
Aug 9, 2023
| assign-symbol(diode-sym(DiodeLED)) | ||
| assign-landpattern(lp-led-maker) | ||
|
|
||
| defn percent-to-li (percent:Double, min-li:Double, max-li:Double) -> Double : |
There was a problem hiding this comment.
You might want to spell out what li is -> light-intensity?
bhusang
reviewed
Aug 9, 2023
| net (reg.VOUT power-out.vdd) | ||
|
|
||
| bypass-cap-strap(reg.VCC, power-in.gnd, ["capacitance" => 0.1e-6, "_exist" => ["vendor_part_numbers.lcsc"]]) | ||
| bypass-cap-strap(reg.VOUT, power-out.gnd, ["capacitance" => 0.1e-6, "_exist" => ["vendor_part_numbers.lcsc"]]) |
There was a problem hiding this comment.
Carl just made a change to ocdb to enable to usage of Tuple similar to your pending PR. You should ensure that this code works with the latest OCDB when his PR is merged.
bhusang
requested changes
Aug 9, 2023
|
@bhusang sorry, I just realized there was pending work to be done on this. Could I still complete these changes or is this design already too outdated to be used for the cookbook? |
|
Hi Nazar,
No need to worry about this.
Regards,
-Bhusan
On Aug 29, 2024 at 3:14 AM -0700, hypadr1v3 ***@***.***>, wrote:
@bhusang<https://github.com/bhusang> sorry, I just realized there was pending work to be done on this. Could I still complete these changes or is this design already too outdated to be used for the cookbook?
—
Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDNBPJO7E7PTRORP6AIMGDZT3X6NAVCNFSM6AAAAABNKCWZSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGIZTSMBWHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final design for the SD card reader is complete.