Skip to content

[SYMPP-HOTFIX] Avoid duplicate projection during package creation - #683

Merged
JJLiebig merged 1 commit into
mainfrom
fix/package-creation-projection-timeout
Sep 8, 2026
Merged

JJLiebig merged 1 commit into
mainfrom
fix/package-creation-projection-timeout

Conversation

@JJLiebig

@JJLiebig JJLiebig commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Context

Daedalus package creation exceeded the 15-second database transaction deadline while redacting a second full dashboard projection for its 611-package WorkRequest.

TL;DR

Reuse the loaded dashboard detail and refresh only the product tree after recording its revision.

Summary

  • Remove the duplicate full projection inside package, group, and dependency mutation transactions.
  • Preserve atomic revision recording and return the freshly recorded revision.
  • Copied-ledger measurement: 5.19s before, 2.82s after; the installed runtime has not been changed.

Alternatives

  • Raising the timeout would retain the duplicated work; reuse removes its cause without changing the deadline.

Test Plan

  • 40 focused tests across slicing, multi-repo scope, revision idempotency, product trees, groups, and dependencies.
  • Regression fails on the old implementation and passes with the fix; returned revision matches storage.
  • Formatting, specs.check, and strict Credo pass.
  • Copied 611-package ledger preserves the product tree while refreshing the revision.
  • Fast Review Suite: cleanup pass and both correctness reviewers clean (rvw_7df591a2).
  • Full-suite and release gates omitted: this change is confined to projection reuse; relevant shared callers are covered.

Reuse the detail loaded for the product tree revision, refreshing only
the tree after recording it. Daedalus package creation exhausted the
15-second transaction deadline redacting a duplicate full projection.

Validate the returned revision and bound progress-history reads in the
existing slicing test. All 26 focused tests pass; the regression fails
against the previous implementation.

Co-authored-by: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1a2c17e5-7fad-4d16-993c-3f98458edffd


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JJLiebig
JJLiebig marked this pull request as ready for review September 8, 2026 19:45
@JJLiebig
JJLiebig merged commit 17ceea2 into main Sep 8, 2026
25 checks passed
@JJLiebig
JJLiebig deleted the fix/package-creation-projection-timeout branch September 8, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant