Skip to content

[SYMPP-OPS] Add a Windows server upgrade command - #684

Merged
JJLiebig merged 3 commits into
mainfrom
feat/local-upgrade-command
Sep 8, 2026
Merged

JJLiebig merged 3 commits into
mainfrom
feat/local-upgrade-command

Conversation

@JJLiebig

@JJLiebig JJLiebig commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Context

Updating the installed S++ server currently takes manual shutdown, marketplace upgrade, and startup steps while existing bridges may try to recover the old server.

TL;DR

Add a Windows script that stops S++, upgrades its marketplace, and restarts the installed runtime.

Summary

  • Add scripts/upgrade-spp.ps1, with process identity checks and a -WhatIf preview.
  • Block Node and PowerShell bridge recovery during upgrade; attempt restart even when the upgrade fails.
  • Resolve the newly installed launcher after version changes.
  • Document installed-runtime usage and when existing sessions need a reload.

Alternatives

  • Keep the manual sequence: easy to race automatic bridge recovery or leave the server down after an upgrade failure.
  • Upgrade before shutdown: valid manually, but does not provide the requested stop/upgrade/start command.

Test Plan

  • Windows lifecycle check: shutdown order, upgrade failure recovery, identity rejection, preview, and lock cleanup.
  • Version-changing upgrade uses the new launcher; both recovery paths are excluded during replacement.
  • Real installed-runtime -WhatIf preview; no live restart performed for this PR.
  • Formatting, strict Credo, and git diff --check.
  • Fast Review Suite: both final reviewers clean (rvw_a2d3e679).
  • Full application suites omitted: this script does not change the application runtime; lifecycle validation is focused.

Stop the managed backend, upgrade its marketplace, and restart through
the installed launcher. Hold the bridge recovery lock during the upgrade
and attempt restart even when the upgrade fails.

Document usage and cover process identity, dry run, shutdown ordering,
restart after failure, and lock cleanup with an isolated lifecycle check.

Co-authored-by: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bd9ae313-7874-4852-9689-406a272300ed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

JJLiebig and others added 2 commits September 8, 2026 22:39
Keep live bridges supported for same-version backend refreshes. Require sessions closed before version-changing upgrades and remove the unconditional reconnect claim.

Co-authored-by: Codex <codex@openai.com>
@JJLiebig
JJLiebig marked this pull request as ready for review September 8, 2026 20:47
@JJLiebig
JJLiebig merged commit 482c4b1 into main Sep 8, 2026
26 checks passed
@JJLiebig
JJLiebig deleted the feat/local-upgrade-command branch September 8, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant