Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to logLevels #251

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hmenzagh
Copy link
Contributor

@hmenzagh hmenzagh commented Jul 16, 2020

Simple pull request to change logLevels (This PR is kind of opinionated).
Changes:

  • Route creations are now on the INFO level (changes made to the .md and the seed file too)
  • Request are on the INFO level too
  • Request results are on the NOTE level

This is to comply with le descriptions of INFO as being minor informations and NOTE as being verbose.

An argument could be made that the route creations should be on the NOTE level but since it only concerns a single batch output at the beginning of the execution and that this information can be useful to ensure that everything went well without being too verbose I believe the INFO level is appropriate.

Feel free to ask me to change my PR if you don't agree !

@hmenzagh hmenzagh changed the title Pull request without esm Changes to logLeves Jul 16, 2020
@hmenzagh hmenzagh changed the title Changes to logLeves Changes to logLevels Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          24       24           
  Lines        2805     2805           
=======================================
  Hits         2286     2286           
  Misses        519      519           
Impacted Files Coverage Δ
utilities/rest-helper-factory.js 80.39% <0.00%> (ø)
utilities/handler-helper.js 78.82% <66.66%> (ø)
utilities/handler-helper-factory.js 93.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a911ade...6fdb815. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant