Added advantage description #16
Conversation
Edzelopez
force-pushed
the
add-advantage
branch
from
868ca4b
to
36dc51c
Compare
cdntaxreceipts.functions.inc
Outdated
| @@ -618,7 +610,7 @@ function cdntaxreceipts_configure_inkind_fields() { | |||
| $group = array( | |||
| 'title' => 'In-kind donation fields', | |||
| 'extends' => array( 'Contribution' ), | |||
| 'extends_entity_column_value' => array( $contrib_type_id ), | |||
| 'extends_entity_column_value' => [$financialTypeID], | |||
There was a problem hiding this comment.
What fields are supposed to go into this group, and why is that not part of this PR? On test2, when I create a contribution with fund of In-kind, then this field set opens and shows
DESCRIPTION OF PROPERTY * |
APPRAISED BY * |
ADDRESS OF APPRAISER * |
ORIGINAL COST
There was a problem hiding this comment.
@JoeMurray the custom fields are declared just few lines below at line 626 which is a part of the old code here - https://github.com/jake-mw/CDNTaxReceipts/blob/master/cdntaxreceipts.functions.inc#L613
|
@monishdeb I found an issue with your delete query and have fixed it in ee5e340 I have also tried to ensure that the inkind receipting is added as well @Edzelopez A question do we need to set the GL Code for the revenue account in the upgrade? |
…ue financial account as well
CRM-954: Token fixes for CDN taxreceipt thank-you form
No description provided.