issue#4 fix

[monishdeb]

See #4

[MegaphoneJon]

Hi @monishdeb - I tested this fix, and it seems to work. Additionally, it fixes a bug I hadn't realized until yesterday was tied to this extension - the length of time it takes to load the search results on this page usually causes a timeout.

Note, however, that I don't have any grant entries to test currently.

[MegaphoneJon]

I also think this improves performance - I believe there was a performance issue in the existing function, but I'm not going to try to benchmark it. While I can't speak to the grant side of things, this is all around better than previously.

[MegaphoneJon]

I've tested further and noticed two issues:

• Clicking View next to a transaction doesn't bring it up as a snippet.
• I'm having an issue that I can't quite figure out that differs between my live and dev environments. On my live site, the search doesn't work at all, with calls to civicrm/getfinancialtransaction which is in the templates/CRM/Financial/Form/BatchTransaction.tpl, but of course has been removed from the PHP. I'll investigate further.

[MegaphoneJon]

OK, the issue was some bad caching on my dev site. I think you'll also need to remove templates/CRM/Financial/Form/BatchTransaction.tpl.

[monishdeb]

@MegaphoneJon Sorry for the delay. Yes, that was a miss on my part and I have updated the PR. Please check now.