[FIX] 잘못된 URI 엔드포인트 수정 #288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. Walkthrough
Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Admin as Admin Client
participant Sec as SecurityFilterChain
participant C as AttendController
participant U as GetAttendantInfoUsecase
participant S as AttendService
participant R as AttendRepository
note over Admin,S: 출석 통계 조회 (page,size,activeStatus,startDate,endDate)
Admin->>Sec: GET /api/attend/statistic
Sec-->>Admin: 401/403 if not ROLE_ADMIN
Sec->>C: Authorized request
C->>U: getStatistics(page,size,activeStatus,startDate,endDate)
U->>S: delegate
S->>S: 날짜 범위 계산(입력 or 학기기간)
alt activeStatus 제공
S->>R: getStatistics(start,end,LATE,ABSENT,activeStatus, pageable)
else 미제공
S->>R: getStatistics(start,end,LATE,ABSENT, pageable)
end
R-->>S: Page<Object[]>
S->>S: MemberStatistics로 매핑, 정렬/페이징 유지
S-->>U: PageResponse<MemberStatistics>
U-->>C: PageResponse<MemberStatistics>
C-->>Admin: 200 OK, ApiResponse(SuccessBody)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (33)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✒️ 작업 내용
스크린샷 🏞️ (선택)
💬 REVIEWER에게 요구사항 💬
Summary by CodeRabbit