Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PurchaseOrder): always return PublicTicketLink for simplicity #55

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat(PurchaseOrder): always return PublicTicketLink for simplicity #55

merged 1 commit into from
Oct 1, 2024

Conversation

joseglego
Copy link
Member

Summary

  • Instead of returning PO Public Link, return Ticket, for simplicity and no edge cases.

@joseglego joseglego requested a review from fforres October 1, 2024 02:42
@joseglego joseglego force-pushed the lego/feat/always-ticket branch from b60d446 to e248444 Compare October 1, 2024 02:45
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024 •
edited
Loading

Deploying tickets with  Cloudflare Pages  Cloudflare Pages

Latest commit: e248444
Status: ✅  Deploy successful!
Preview URL: https://81193a2b.tickets.pages.dev
Branch Preview URL: https://lego-feat-always-ticket.tickets.pages.dev

View logs

@joseglego joseglego merged commit dddb336 into main Oct 1, 2024
4 checks passed
@joseglego joseglego deleted the lego/feat/always-ticket branch October 1, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fforres fforres Awaiting requested review from fforres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joseglego