Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace match with let ... else where applicable #102

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

JSorngard
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (68598a4) to head (fe95835).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/generate.rs 50.00% 1 Missing ⚠️
src/sieve.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   89.65%   89.62%   -0.04%     
==========================================
  Files          11       11              
  Lines         996      993       -3     
==========================================
- Hits          893      890       -3     
  Misses        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard
Copy link
Owner Author

JSorngard commented Jan 8, 2025

If these lines are not covered, they weren't before either. If I haven't made any mistakes those lines are also unreachable.

@JSorngard JSorngard merged commit 155a039 into main Jan 8, 2025
6 of 8 checks passed
@JSorngard JSorngard deleted the let_else branch January 8, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant