Skip to content

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Dec 16, 2025

Modernizes the codebase using pyupgrade. This was a very easy win on linting, but I can improve the setup by adding ruff and other common tools in following PRs.

@JBloss1517
Copy link
Collaborator

I love this PR, thanks for submitting it! Now that we are in python 3.10, moving away from the extra imports for things like list, dict, tuple, etc. is great. It looks like the extra imports are still at the top of each file though. Can you remove any unused imports that were created by this upgrade?

@ulgens
Copy link
Contributor Author

ulgens commented Dec 16, 2025

@JBloss1517 I didn't want to go over 34 files manually, I was planning to automate it with ruff and isort.

@JBloss1517
Copy link
Collaborator

Got it. That makes sense. I'll let @JWock82 make the final call on merging this one. But I personally am on board with leaning into leveraging ruff for all of its built in capabilities like linting, import sorting, and formatting. This would consolidate several tools into one config and (very fast) tool.

@ulgens ulgens mentioned this pull request Dec 17, 2025
@ulgens ulgens marked this pull request as draft December 17, 2025 11:18
@ulgens
Copy link
Contributor Author

ulgens commented Dec 17, 2025

I did a bit more testing and I think this will yield to simplest & cleanest result: #299 I'll create another PR to add pyupgrade with ruff.

@ulgens ulgens closed this Dec 17, 2025
@ulgens ulgens deleted the pyupgrade branch December 17, 2025 11:22
@ulgens
Copy link
Contributor Author

ulgens commented Dec 17, 2025

Superseded by #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants