Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue1#10557 #10818

Closed
wants to merge 2 commits into from
Closed

issue1#10557 #10818

wants to merge 2 commits into from

Conversation

Azgharpasha
Copy link

<! I have added a new file from jabref preferences and added some journals in that file from local excel sheet and treid to use that list in that jabref prefernces. It shows all the journal abbreviations that I added as shown in below image .I haven't changed the code. i used the GUI of jabref preferences window .
AS, per the code I checked files of journalAbbreviationLoader.java ,
JournalAbbreviationRepository.java,
JoirnalAbbreviationsPreferences.java
JounralListMvGenerator.java
JournalAbbreviationListChecker.java .

After checking these files I found that jabref itself creates a custom.csv file and use it as backup . we don't need to add new file in code . because jabref an inwritten things that do by itself.

It takes the personal journal lsit and put on tha mv generator and we can easily access by using jabref GUI i.e.; Jabref preferences.-->

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

Hi, thanks for your interest in JabRef and open source programming.
As you have not done any change (except introducing an empty line and thus breaking the checkstyle check),
why did you create a new PR for this and not just commented in the issue?

I will close this PR and would like to ask you to write your findings in the correspondent issue, so we can close it. Thanks.
Refs #10557

@calixtus calixtus closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants