Skip to content

Store journal abbreviation lists in specified directory #12544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix-for-issue-10557

ab635ec
Select commit
Loading
Failed to load commit list.
Open

Store journal abbreviation lists in specified directory #12544

Merge branch 'main' into fix-for-issue-10557
ab635ec
Select commit
Loading
Failed to load commit list.
Trag bot / Trag Review succeeded Apr 9, 2025 in 55s

Trag Code Review

Reviewed files details

Details

[2025-04-09T20:51:21.286Z] code review started
[2025-04-09T20:51:21.286Z] owner: JabRef
[2025-04-09T20:51:21.286Z] repo: jabref
[2025-04-09T20:51:21.286Z] repoUrl: https://github.com/JabRef/jabref
[2025-04-09T20:51:21.286Z] author: adhamahmad
[2025-04-09T20:51:21.286Z] listing pull request files
[2025-04-09T20:51:29.386Z] total file count: 16
[2025-04-09T20:51:29.387Z] eligible file count: 14
[2025-04-09T20:51:33.286Z] pro user privilege applied
[2025-04-09T20:51:33.385Z] getting project rules
[2025-04-09T20:51:35.386Z] model: claude-3-5-sonnet-20240620
[2025-04-09T20:51:35.386Z] on rule review mode: true
[2025-04-09T20:51:35.386Z] glob ignore:
[2025-04-09T20:51:35.386Z] pull number: 12544
[2025-04-09T20:51:35.386Z] projectId: 885262de-6ea4-406f-ab33-0a18e077aaf9
[2025-04-09T20:51:42.786Z] Found 47 existing review comments
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/gui/preferences/journals/AbbreviationsFileViewModel.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTab.fxml
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTab.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/journals/JournalAbbreviationLoader.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/journals/JournalAbbreviationMvGenerator.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/journals/JournalAbbreviationRepository.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/journals/JournalsDirectoryManager.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/util/Directories.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/util/StandardFileType.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/java/org/jabref/logic/util/io/FileUtil.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/main/resources/l10n/JabRef_en.properties
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/test/java/org/jabref/logic/journals/JournalAbbreviationMvGeneratorTest.java
[2025-04-09T20:51:42.786Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.786Z] file: src/test/java/org/jabref/logic/util/io/FileUtilTest.java
[2025-04-09T20:51:42.787Z] file is outside of new changes on pr, skipping
[2025-04-09T20:51:42.787Z] files scanned: 0
[2025-04-09T20:51:42.787Z] lines scanned: 0
[2025-04-09T20:51:42.787Z] rules for project: 61
[2025-04-09T20:51:42.787Z] issues caught by your rules: 0