Restore auto rename feature 2 #12604

wtfjjking · 2025-03-03T16:23:27Z

User now can be able to automatically change their file name when they change their entry data, by just click the checkbox in the preferences ->linked file -> auto rename files if entry changes, and the auto rename functionality will be started,
and also when the user change the entry data, the citation key. Also will automatically change, so they don't need to click the generate button manually,(This automatically change citation key functionality is initiated regardless of the checkbox of the auto rename files functionality is clicked)

Mandatory checks

I own the copyright of the code submitted and I licence it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…ibliography entries change, respecting user preferences and file naming patterns.

…nked files based on entry changes and follows user-defined file naming patterns.

…enaming is enabled based on user preferences. refreshFileLink(): Updates and returns a linked file with the correct relative path based on its current location and database context.

Files are correctly renamed on disk File links in the bibliography entries are properly updated Appropriate fallback mechanisms work when exact renaming isn't possible

Added autoRenameFilesOnEntryChange property to control automatic renaming Updated constructor and related getter/setter methods

Added "Auto rename files if entry changes" checkbox to the preferences UI Implemented data binding with the ViewModel

Added properties and methods for managing the automatic renaming setting Implemented logic for loading and saving settings

Added AUTO_RENAME_FILES_ON_ENTRY_CHANGE constant Updated FilePreferences initialization code

Added internationalization support for UI text

Register automatic file renamer

github-actions

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

github-actions

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. The issues found can be automatically fixed. Please execute the gradle task rewriteRun, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

subhramit · 2025-03-03T16:57:05Z

Hello @wtfjjking
Which tool are you using to make these commits?

wtfjjking · 2025-03-03T17:02:40Z

hello i am using ide to make these commits not in terminal

subhramit · 2025-03-03T17:12:29Z

hello i am using ide to make these commits not in terminal

Can you sign in to GitHub on your IDE properly (using authorization) so that these commits have a traceable author?
Tell me your IDE, I'll help you out.

…is related to the unused method that has been deleted， change bootstrap method so that it has the correct parameters

… more useful comments to the listen method

wtfjjking · 2025-03-03T18:46:10Z

hi i am using intellij here it said that it's already linked to my github account

subhramit · 2025-03-03T19:20:52Z

hello i am using ide to make these commits not in terminal

If you are using IntelliJ and not the terminal, how exactly are you adding the commit descriptions (apart from the message)?

wtfjjking · 2025-03-03T21:47:42Z

oh i figure it out I am using windsurf ide to commit the code

wtfjjking · 2025-03-13T11:46:34Z

src/main/java/org/jabref/gui/openoffice/Bootstrap.java

@@ -105,7 +105,7 @@ private static void insertBasicFactories(XSet xSet, XImplementationLoader xImpLo
     * </pre>
     *
     * @return an array of default commandline options
-     * @see #bootstrap(String[])


here lacks one parameter it should be @see #bootstrap(String[], Path) otherwise the project doesn't compile

I really don't see why openoffice gui files need to be touched here.

Side track: Git Butler is a neat git client for submitting unrelated pull requests while keeping all changes locally merged. - However, this for advanced users, because one will get feedback on the pull requests and need to handle them.

koppor · 2025-03-13T11:56:54Z

oh i figure it out I am using windsurf ide to commit the code

TBH JabRef might not be fitting your coding needs. We are a project where humans curate the code. Especially, we avoid code duplciations nearly at all costs. Windsurf and other AI-driven IDEs just produce code without taking care if there is existing similar functionality.

I suggest either to take this Java learning opportinuity and navigate JabRefs code for yourself using the senior developer IDE IntelliJ or move on to a project which is more relaxed on AI usage.

koppor · 2025-03-13T11:59:46Z

I clicked on update branch to ensure that our latest quality check workflows run.

trag-bot · 2025-03-17T12:50:55Z

@trag-bot didn't find any issues in the code! ✅✨

github-actions · 2025-03-17T12:54:43Z

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files. To ensure consistent styling, we have markdown-lint in place. Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".

koppor · 2025-03-17T18:41:09Z

src/main/java/org/jabref/logic/externalfiles/AutomaticFileRenamer.java

+
+        new Thread(() -> {
+            try {
+                Thread.sleep(500); // avoid renaming the file too frequently


Use background task infrasturcture

koppor · 2025-03-17T18:42:14Z

src/main/java/org/jabref/logic/externalfiles/AutomaticFileRenamer.java

+
+import com.google.common.eventbus.Subscribe;
+
+public class AutomaticFileRenamer {


Use org.jabref.logic.cleanup.RenamePdfCleanup#cleanup instead of self-written class. If this is not possible, comment why.

Jiewu (jack deng) Deng added 10 commits March 3, 2025 10:49

Adds AutomaticFileRenamer to automatically rename linked files when b…

358b764

…ibliography entries change, respecting user preferences and file naming patterns.

feat:Implements automatic file renaming functionality that renames li…

65895ee

…nked files based on entry changes and follows user-defined file naming patterns.

shouldAutoRenameFilesOnEntryChange(): Checks whether automatic file r…

2ec61ab

…enaming is enabled based on user preferences. refreshFileLink(): Updates and returns a linked file with the correct relative path based on its current location and database context.

The tests verify that:

6c3e5cf

Files are correctly renamed on disk File links in the bibliography entries are properly updated Appropriate fallback mechanisms work when exact renaming isn't possible

FilePreferences.java

e77da98

Added autoRenameFilesOnEntryChange property to control automatic renaming Updated constructor and related getter/setter methods

LinkedFilesTab.java & LinkedFilesTab.fxml

690af63

Added "Auto rename files if entry changes" checkbox to the preferences UI Implemented data binding with the ViewModel

LinkedFilesTabViewModel.java

6b786ed

Added properties and methods for managing the automatic renaming setting Implemented logic for loading and saving settings

JabRefCliPreferences.java

2795286

Added AUTO_RENAME_FILES_ON_ENTRY_CHANGE constant Updated FilePreferences initialization code

JabRef_en.properties

b1a41b5

Added internationalization support for UI text

Register automatic citation key generator

7ed45f4

Register automatic file renamer

wtfjjking marked this pull request as draft March 3, 2025 16:23

github-actions bot reviewed Mar 3, 2025

View reviewed changes

- Fix code style issues in AutomaticFileRenamertest file

5d9f31a

github-actions bot reviewed Mar 3, 2025

View reviewed changes

delete unused method, and debug statement, update the test file that …

575aa58

…is related to the unused method that has been deleted， change bootstrap method so that it has the correct parameters

wtfjjking marked this pull request as ready for review March 3, 2025 18:29

wtfjjking marked this pull request as draft March 3, 2025 18:31

delete the case check when no citation key but linked file exist, add…

28b80e1

… more useful comments to the listen method

wtfjjking marked this pull request as ready for review March 3, 2025 18:46

Jiewu (jack deng) Deng and others added 2 commits March 9, 2025 20:12

add a description of the functinality changed in CHANGELOG.md

1f3c1d1

Merge branch 'main' into restore-auto-rename-feature-2

c93e2b4

wtfjjking commented Mar 13, 2025

View reviewed changes

koppor marked this pull request as draft March 13, 2025 11:57

koppor added the status: changes required Pull requests that are not yet complete label Mar 13, 2025

Merge branch 'main' into restore-auto-rename-feature-2

9f81a8e

Merge branch 'main' into restore-auto-rename-feature-2

8771120

koppor requested changes Mar 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore auto rename feature 2 #12604

Restore auto rename feature 2 #12604

wtfjjking commented Mar 3, 2025 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

wtfjjking Mar 13, 2025

subhramit Mar 13, 2025

koppor Mar 13, 2025

koppor commented Mar 13, 2025

koppor commented Mar 13, 2025

trag-bot bot commented Mar 17, 2025

github-actions bot commented Mar 17, 2025

koppor Mar 17, 2025

koppor Mar 17, 2025


		import com.google.common.eventbus.Subscribe;

		public class AutomaticFileRenamer {

Restore auto rename feature 2 #12604

Are you sure you want to change the base?

Restore auto rename feature 2 #12604

Conversation

wtfjjking commented Mar 3, 2025 • edited Loading

Mandatory checks

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

subhramit commented Mar 3, 2025

wtfjjking commented Mar 3, 2025

wtfjjking Mar 13, 2025

Choose a reason for hiding this comment

subhramit Mar 13, 2025

Choose a reason for hiding this comment

koppor Mar 13, 2025

Choose a reason for hiding this comment

koppor commented Mar 13, 2025

koppor commented Mar 13, 2025

trag-bot bot commented Mar 17, 2025

github-actions bot commented Mar 17, 2025

koppor Mar 17, 2025

Choose a reason for hiding this comment

koppor Mar 17, 2025

Choose a reason for hiding this comment

wtfjjking commented Mar 3, 2025 •

edited

Loading