-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On clicking on the symbol in the consistency check results table select the respective field #12658
base: main
Are you sure you want to change the base?
On clicking on the symbol in the consistency check results table select the respective field #12658
Conversation
Recording.2025-03-09.mp4There is one problem with it: it works fine and correctly checks if the field exists in the Entry Editor, but for some fields, it behaves unexpectedly by opening the AI Chat tab. |
Don't want to bring bad news, but for me this doesn't work at all...
Okay, after recheck, some columns are working. Columns that don't work:
One of the biggest problems I'm having is that when it goes to AI tab, after closing the "Consistency check", I can't switch to other editing tab |
@@ -1035,6 +1035,7 @@ required\ field\ is\ present=required field is present | |||
optional\ field\ is\ present=optional field is present | |||
unknown\ field\ is\ present=unknown field is present | |||
field\ is\ absent=field is absent | |||
Field\ does\ not\ exist\ in\ the\ editor!=Field does not exist in the editor! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid exclamation marks at the end of a sentence. They are more for screaming. Use a dot to end the sentence.
At org.jabref.gui.integrity.IntegrityCheckDialog#onSelectionChanged, we are also using that method.
Maybe you need to add You can leave LOGGER.trace statements in - and just remove the tinylog.properties configuraiton. |
Is there a library which can be checked? |
Just a thought, we can use the Singleton design pattern instead of creating a new |
Recording.2025-03-16.mp4It can be checked on |
You mean the "Field does not exist in the editor!" error message? (I needed to make screenshots to see it in my firefox video player) If a field does not exist in the entry editor is a WTF thing. Something is wrong in the code then. -- Unknown fields are gathered in the "Other fields" tab - for each field present in BibEntry data structure, there is an entry editor. The only issue I can think of that "field aliasses" are not properly handled.
If one has |
Yeah, I mean to say that the aliases does not exist. |
It works fine, "field does not exist" means when the entire column Please try on |
The check fails because I cannot use any link to the issue, as it is a follow-up to the feature. |
@trag-bot didn't find any issues in the code! ✅✨ |
Your pull request conflicts with the target branch. Please merge |
Refers to JabRef/blog.jabref.org#109 (comment)
This PR ensures that clicking on a symbol in the Consistency Check Results table navigates to the Entry Editor for the corresponding field.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)