Added "Add example entry" and "Import existing PDFs" when a library is empty #12741
Conversation
-Ensures button is hidden when entries exist but are filtered -Add listeners to track database and table entry changes
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
-used localization -added styles for button
…e-12662 # Conflicts: # src/main/java/org/jabref/gui/maintable/MainTable.java
-checks if directory exists -triggers search for unlinked files ( if directory exists ) -Shows notification and open library properties ( if directory doesn't exist)
| dialogService.showWarningDialogAndWait( | ||
| Localization.lang("File directory is not set or does not exist!"), |
There was a problem hiding this comment.
The warning message ends with an exclamation mark, which should be avoided in UI messages as per guidelines. Should end with a period instead.
There was a problem hiding this comment.
Used Key which was already defined in properties , Should i update ?
There was a problem hiding this comment.
Yes, please. Do it in a separate PR so that we can integrate this fast.
If you feel uncomfortable to create a new branch based on main, you can use git town hack.
There was a problem hiding this comment.
I noticed that this message was originally used in an Error Dialog, while the review comment specifically refers to a Warning message. Should I still proceed with making this a global change and remove the exclamation mark?
There was a problem hiding this comment.
Also , After reviewing the properties file, I found that many messages contain exclamation marks. Should I update all of them for consistency ?
There was a problem hiding this comment.
Yes, but please think whether it could be critical error, then leave the !.
sanjyot242
changed the title
…e-12662 # Conflicts: # src/main/java/org/jabref/gui/Base.css
| dialogService.showWarningDialogAndWait( | ||
| Localization.lang("File directory is not set or does not exist!"), |
There was a problem hiding this comment.
Yes, but please think whether it could be critical error, then leave the !.
| @@ -2875,6 +2875,12 @@ Editor\ related=Editor related | |||
| Title\ related=Title related | |||
| Entry\ fields=Entry fields | |||
| Please\ configure\ a\ file\ directory=Please configure a file directory | |||
| Add\ example\ entry=Add example entry | |||
| No\ content\ in\ table=No content in table | |||
There was a problem hiding this comment.
I don't get why this is here - I also see it in current JabREf
There was a problem hiding this comment.
Currently the following message is defined in control.properties ( javafx ) .
and fetched using ControlResources.getString("TableView.noContent") .
For consistency i used Localization.lang and hence had to add it in properties .
|
I need to try out the directory. Global prefs:
|
- Removed Unnecessary comments - Used withField for BibEntry instead of setField
-updating with period
|
👋 Hey! As a free user, you're receiving reviews for every 5th PR. Upgrade to get reviews on every pull request and boost your code quality! Learn more here 🚀 |
Hey , Could you please explain in detail about the global prefs checks . Thanks |
Closes #12662
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)