Add "Add JabRef suggested groups" #12746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new feature to automatically create useful suggested groups: - "Entries without linked files" group to find entries missing file attachments - "Entries without groups" group to find entries not assigned to any group The feature is accessible through context menu on the "All entries" group. Add comprehensive test cases that verify: - Groups are correctly created with search expressions "file !=~.*" and "groups !=~.*" - Duplicate groups are not created when the feature is used multiple times - Only missing groups are added when some suggested groups already exist - Both scenarios are tested: adding missing "files" group and missing "groups" group - Changes are properly written to metadata - Selected groups are updated after adding suggested groups Add required localization strings to support this feature.
This reverts commit 36a2ae6.
Add new feature to automatically create useful suggested groups: - "Entries without linked files" group to find entries missing file attachments - "Entries without groups" group to find entries not assigned to any group The feature is accessible through context menu on the "All entries" group. Add comprehensive test cases that verify: - Groups are correctly created with search expressions "file !=~.*" and "groups !=~.*" - Duplicate groups are not created when the feature is used multiple times - Only missing groups are added when some suggested groups already exist - Both scenarios are tested: adding missing "files" group and missing "groups" group - Changes are properly written to metadata - Selected groups are updated after adding suggested groups Add required localization strings to support this feature.
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
reviewed
Mar 16, 2025
Siedlerchr
requested changes
Mar 16, 2025
| @@ -205,7 +207,7 @@ public void addSuggestedSubGroup(GroupNodeViewModel parent) { | |||
|
|
|||
| if (!hasEntriesWithoutFiles) { | |||
| SearchGroup withoutFilesGroup = new SearchGroup( | |||
| Localization.lang("Entries without linked files"), | |||
| Localization.lang(ENTRIES_WITHOUT_LINKED_FILES), | |||
There was a problem hiding this comment.
This is now how it works https://devdocs.jabref.org/code-howtos/localization.html#general-hints
|
I’ve fixed it as you suggested. Thanks a lot for your help, @Siedlerchr!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes (#12659)
This PR resolves #12659 by adding a "Add JabRef suggested groups" option to the "All entries" context menu, which appends the groups "Entries without linked files" and "Entries without groups" to the list if they don’t already exist, and disables the option when both are present; it includes the logic and UI implementation, unit tests covering all cases (no groups, one group, both existing), and an update to
CHANGELOG.md.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)