Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Test) commit submodules #12755

Closed
wants to merge 7 commits into from
Closed

Conversation

subhramit
Copy link
Member

To test #12752

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Sorry, something went wrong.

@subhramit
Copy link
Member Author

@subhramit subhramit requested a review from koppor March 16, 2025 21:27
@koppor
Copy link
Member

koppor commented Mar 16, 2025

@koppor false positive? JabRef/jabref/actions/runs/13887489384/job/38854160250?pr=12755

I think, I mixed up again pull_request ( contributor branch with all changes, but not with full token rights) and pull_request_target (main branch with full token rights). Check is now done at pull_request - fa74258

@koppor
Copy link
Member

koppor commented Mar 16, 2025

Still not working. Need to check.

@subhramit subhramit marked this pull request as draft March 16, 2025 21:46
@subhramit
Copy link
Member Author

@koppor it seems to me like we are triggering the error when NO submodule changes are detected (! in front)

@koppor
Copy link
Member

koppor commented Mar 16, 2025

@koppor it seems to me like we are triggering the error when NO submodule changes are detected (! in front)

The -vz in grep reverses the grep change

@subhramit
Copy link
Member Author

Woohoo done

Copy link
Contributor

Your pull request modified git submodules.

Please follow our FAQ on submodules to fix.

@koppor koppor closed this Mar 16, 2025
@subhramit subhramit deleted the test-submodules branch March 16, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants