-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
considering multiple spaces as separate user block by replacing it with " and " #12757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that all tests go pass. I would have written a more closer check:
src/test/java/org/jabref/logic/importer/AuthorListParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/AuthorListParserTest.java
Outdated
Show resolved
Hide resolved
This existing test case is failing, Looks like the current requirement is contradicting, I need your inputs, What if there is multiple spaces in between the first and second name? |
src/test/resources/org/jabref/logic/importer/fileformat/RisImporterTest1.ris
Outdated
Show resolved
Hide resolved
Maybe, it the "guard" to the rewrite is to check for non existance of copmma (,) |
…ng it with " and "" This reverts commit ca6e337
Co-authored-by: Oliver Kopp <[email protected]>
@trag-bot didn't find any issues in the code! ✅✨ |
@rishivardhanmm Thank you for the quick replies. Now, this should be good to go. Let's see if we encounter some erorr reports by our users... Getting heuristics right is always hard. |
Thank you for your patience in review as well, I understand, Feel free to assign issues to me that comes back related to this. |
Closes #12701
considering multiple spaces as separate user block by replacing it with " and "
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)