Switch Badges #12777
Switch Badges #12777
Conversation
|
|
||
| [](https://devdocs.jabref.org/) | ||
| [](https://www.codetriage.com/jabref/jabref) | ||
| [](https://gitter.im/JabRef/jabref?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) |
There was a problem hiding this comment.
I think we can keep this (gitter chat link)? Or should this be added as a point below?
There was a problem hiding this comment.
I don't remember if that's how I joined gitter, or if it was the issue greeting. Although now when I look at it, it is hard to notice - true. Maybe because there were so many badges?
There was a problem hiding this comment.
I you like them, I also think they can be listed as bullet list somehwere. But then in docs -> code quality?
Removing the rest is fine - I am sure I never looked at the rest.
There was a problem hiding this comment.
It is at "Choosing a task" and at the welcome mesasge, too. Thus, I think, it can be removed.
| @@ -64,15 +64,7 @@ You can use our [GitHub issue tracker](https://github.com/JabRef/jabref/issues) | |||
|
|
|||
| An explanation of donation possibilities and usage of donations is available at our [donations page](https://donations.jabref.org). | |||
|
|
|||
| ## Contributing | |||
|
|
|||
| [](https://devdocs.jabref.org/) | |||
There was a problem hiding this comment.
Are linked often in CONTRIBUTING.md
| ## Contributing | ||
|
|
||
| [](https://devdocs.jabref.org/) | ||
| [](https://www.codetriage.com/jabref/jabref) |
There was a problem hiding this comment.
Not really maintained by us
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
@trag-bot didn't find any issues in the code! ✅✨ |
| We use [GitHub Actions](https://github.com/JabRef/jabref/actions) for executing the tests after each commit. | ||
| For developing, it is sufficient to only run the associated test locally (see example [here](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-12-build.html)) for the classes you changed. | ||
| GitHub will report any other failure. To find solutions to the most common errors that lead to such failures, check our [FAQ page](https://devdocs.jabref.org/code-howtos/faq). |
There was a problem hiding this comment.
Information lost? I think this link can be useful.
Line 238 (226 before changes) of contributing has:
You can also directly run the specific test in your IDE.
The test "`LocalizationConsistencyTest`" is placed under `src/test/java/org.jabref.logic.l10n/LocalizationConsistencyTest.java`.
Find more information in the [JabRef developer docs](https://devdocs.jabref.org/code-howtos/localization.html).
But it is only under the context of localisation.
There was a problem hiding this comment.
@koppor your view about this? [in case it got buried]
|
I would keep gitter chat as well |
It is linked in CONTRIBUTE.md and in the message at assignment reply. |
Before:
After:
I know, I liked these badges some years ago. With our target group, I think, they are not useful at all - APIdia is :)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)