Skip to content

Support customized entry types in BibliographyConsistencyCheck #13799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Support customized entry types in BibliographyConsistencyCheck #13799

Changes from 2 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
94e1770
feat: draft PR for substituting `BibEntryTypesManager` instead of `Bi…
dcarpentiero Sep 1, 2025
b42b7c8
Merge remote-tracking branch 'origin/main' into customized-entry-type…
dcarpentiero Sep 1, 2025
274d859
fix: removing comments
dcarpentiero Sep 2, 2025
b9d69c2
fix: resolving conflicts
dcarpentiero Sep 2, 2025
b2bc3a4
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 2, 2025
8128685
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 2, 2025
831ed3b
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 3, 2025
9942817
fix: modern best practices: Set.copyOf() instead of new HashSet<>()
dcarpentiero Sep 3, 2025
ff8006e
Merge remote-tracking branch 'origin/customized-entry-types-13794' in…
dcarpentiero Sep 3, 2025
d453516
feat: double constructor: a default and accepting manager constructor
dcarpentiero Sep 3, 2025
53b83d9
Update jablib/src/main/java/org/jabref/logic/quality/consistency/Bibl…
dcarpentiero Sep 4, 2025
b7145af
feat: passing down the BibEntryTypes manager to BibliographyConsisten…
dcarpentiero Sep 4, 2025
baeff03
feat: starting substituting CliPreferences with JabRefCliPreferences …
dcarpentiero Sep 4, 2025
3a79c98
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 4, 2025
d302f7c
fix: BibliographyConsistencyCheck now accept a CliPreference passed d…
dcarpentiero Sep 4, 2025
76394d7
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 5, 2025
3f97a75
feat: `BibliographyConsistencyCheckTest`, `BibliographyConsistencyChe…
dcarpentiero Sep 8, 2025
37416ff
fix: passing `getCustomEntryTypes` parameter to `JabKit`, `CheckConsi…
dcarpentiero Sep 8, 2025
66b2bbf
fix: typo
dcarpentiero Sep 8, 2025
2031f0e
fix: typo
dcarpentiero Sep 8, 2025
ad131c6
fix: typo and parameter order
dcarpentiero Sep 8, 2025
9c24a2f
fix: removal unnecessary parameter
dcarpentiero Sep 8, 2025
ff9a529
fix: removal unnecessary parameter
dcarpentiero Sep 8, 2025
d6d8278
fix: removing double import--using `argumentProcessor.cliPrefences`
dcarpentiero Sep 9, 2025
0d7e37d
fix: using `mockito` for testing
dcarpentiero Sep 9, 2025
1fc3810
fix: resolving conflicts
dcarpentiero Sep 9, 2025
d30b731
fix: resolving conflicts
dcarpentiero Sep 9, 2025
462657a
fix: resolving conflicts
dcarpentiero Sep 9, 2025
704885f
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 9, 2025
c321b78
fix: removing double imports
dcarpentiero Sep 9, 2025
79af35f
fix: removing double imports
dcarpentiero Sep 9, 2025
3befca7
fix: removing `CliPreferences` redundancy–– `GuiPreferences` already …
dcarpentiero Sep 10, 2025
7125b76
fix: `PreferencesMigrations.runMigrations(preferences);` now accepts …
dcarpentiero Sep 10, 2025
e580f9a
fix: passing null to `getCustomEntryTypesRepository` to get the first…
dcarpentiero Sep 10, 2025
d3bfbd8
fix: adding no-parameter `getCustomEntryRepository` method to `CliPre…
dcarpentiero Sep 10, 2025
6ed613a
fix: typo
dcarpentiero Sep 10, 2025
6cc90e2
fix: adding missing method to `BibliographyConsistencyCheckTest`
dcarpentiero Sep 10, 2025
f1adef0
fix: including previously excluded entries that have consistent (miss…
dcarpentiero Sep 10, 2025
6cea857
fix: typo
dcarpentiero Sep 10, 2025
c899efa
feat: now accepting entries that present consistent (eg. all absent) …
dcarpentiero Sep 11, 2025
3e6c4b1
fix: when filtering entries, checking if the entry has a differing fi…
dcarpentiero Sep 11, 2025
d681cd8
fix: when filtering entries, checking if the entry has a differing fi…
dcarpentiero Sep 11, 2025
5040b0c
Merge branch 'main' into customized-entry-types-13794
dcarpentiero Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions jablib/src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.jabref.model.database.BibDatabaseMode;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.BibEntryType;
import org.jabref.model.entry.BibEntryTypesManager;
import org.jabref.model.entry.field.Field;
import org.jabref.model.entry.field.InternalField;
import org.jabref.model.entry.field.SpecialField;
Expand All @@ -33,13 +34,18 @@

public class BibliographyConsistencyCheck {

private static final Set<EntryType> BIBLATEX_TYPES = BiblatexEntryTypeDefinitions.ALL.stream()
.map(BibEntryType::getType)
.collect(Collectors.toSet());
// private static final Set<EntryType> BIBLATEX_TYPES = BiblatexEntryTypeDefinitions.ALL.stream()
// .map(BibEntryType::getType)
// .collect(Collectors.toSet());

private static final Set<EntryType> BIBTEX_TYPES = BibtexEntryTypeDefinitions.ALL.stream()
.map(BibEntryType::getType)
.collect(Collectors.toSet());
private static final Set<BibEntryType> BIBLATEX_TYPES = new HashSet<>(new BibEntryTypesManager()
.getAllTypes(BibDatabaseMode.BIBLATEX));

// private static final Set<EntryType> BIBTEX_TYPES = BibtexEntryTypeDefinitions.ALL.stream()
// .map(BibEntryType::getType)
// .collect(Collectors.toSet());
private static final Set<BibEntryType> BIBTEX_TYPES = new HashSet<>(new BibEntryTypesManager()
.getAllTypes(BibDatabaseMode.BIBTEX));

private static final Set<Field> EXPLICITLY_EXCLUDED_FIELDS = Set.of(
InternalField.KEY_FIELD, // Citation key
Expand Down Expand Up @@ -174,7 +180,7 @@ private static void collectEntriesIntoMaps(BibDatabaseContext bibContext, Map<En
BibDatabaseMode mode = bibContext.getMode();
List<BibEntry> entries = bibContext.getEntries();

Set<EntryType> typeSet = switch (mode) {
Set<BibEntryType> typeSet = switch (mode) {
case BIBLATEX -> BIBLATEX_TYPES;
case BIBTEX -> BIBTEX_TYPES;
};
Expand Down
Loading