Slightly improved visual consistency of the CitationkeyTab #13939
Conversation
| setOnAction(_ -> new HelpAction(helpFile, dialogService, externalApplicationsPreferences).execute()); | ||
| } | ||
|
|
||
| public final StringProperty helpUrlProperty() { |
There was a problem hiding this comment.
What is the idea behind this? updating the help url dynamically?
There was a problem hiding this comment.
So that we can set this in the FXML :)
Co-authored-by: Subhramit Basu <[email protected]>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
|
Localization, rest lgtm |
| HBox.hgrow="ALWAYS"/> | ||
| </HBox> | ||
| <HelpButton | ||
| helpUrl="https://docs.jabref.org/setup/citationkeypatterns#replace-via-regular-expression" |
There was a problem hiding this comment.
I would move this as a constant to URL class to have it in a single place
| text="%Key patterns"/> | ||
| <VBox alignment="BOTTOM_CENTER" > | ||
| <HelpButton | ||
| helpUrl="https://docs.jabref.org/setup/citationkeypatterns" |
There was a problem hiding this comment.
same here, move it to Urls class so that there is a single class with all urls, easier for changing
|
still not a fan of putting the direct URLs in the FXML. |
|
Might be great if this can be optional. Is almost ready, we should talk briefly in the next devcall and make a decision here - even finalize it, so we can move forward here. |
calixtus
added
component: ui
status: devcall
component: preferences
status: ready-for-review
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
We should discuss. I think having the URLs at the help buttons makes it easy to add new ones. Having the URLs separately, maintenance could be improved (but we have Ctrl+Shift+F to search for URLs needed to change).
| <HBox alignment="BOTTOM_LEFT" spacing="8.0"> | ||
| <Label styleClass="sectionHeader" text="%Key patterns"/> | ||
| <Button fx:id="keyPatternHelp" styleClass="icon-button,narrow" /> | ||
| <HelpButton helpUrl="https://docs.jabref.org/setup/citationkeypatterns"/> |
There was a problem hiding this comment.
This is the improvement. Reads nice!
|
Question is, how often do we think, these urls will change? |
I have a very workaround-ish idea to deal with that. We can list and check all such links (not limited to this PR) that are used in fxmls. |
calixtus
changed the title
* upstream/main: New study.yml format (JabRef#13844) Separate issue linking workflows, make them run on `edited` (JabRef#14121)
|
Decision was made with @Siedlerchr to move forward without the tooltip, to get moving. |
) * fix: Slightly improved visual consistency of the CitationkeyTab * docs: Update CHANGELOG * docs: Update CHANGELOG.md Co-authored-by: Subhramit Basu <[email protected]> * fix: Make the HelpButton's weird method more clear * Small fixes * line breaks * Remove artifact * Remove artifact * l10n --------- Co-authored-by: Subhramit Basu <[email protected]> Co-authored-by: Christoph <[email protected]> Co-authored-by: Carl Christian Snethlage <[email protected]>
5 participants
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/786
Steps to test
Open JabRef > Citation key tab
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)