fix: Slightly improved visual consistency of the CitationkeyTab #13939
Conversation
| setOnAction(_ -> new HelpAction(helpFile, dialogService, externalApplicationsPreferences).execute()); | ||
| } | ||
|
|
||
| public final StringProperty helpUrlProperty() { |
There was a problem hiding this comment.
What is the idea behind this? updating the help url dynamically?
There was a problem hiding this comment.
So that we can set this in the FXML :)
Co-authored-by: Subhramit Basu <[email protected]>
|
Your pull request needs to link an issue correctly. To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:
Examples
|
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
|
Localization, rest lgtm |
|
|
||
| HELP(Localization.lang("Online help"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), | ||
| HELP_GROUPS(Localization.lang("Open Help page"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), | ||
| HELP_KEY_PATTERNS(Localization.lang("Help on key patterns"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), |
There was a problem hiding this comment.
The text was displayed in a tooltip
| HBox.hgrow="ALWAYS"/> | ||
| </HBox> | ||
| <HelpButton | ||
| helpUrl="https://docs.jabref.org/setup/citationkeypatterns#replace-via-regular-expression" |
There was a problem hiding this comment.
I would move this as a constant to URL class to have it in a single place
| text="%Key patterns"/> | ||
| <VBox alignment="BOTTOM_CENTER" > | ||
| <HelpButton | ||
| helpUrl="https://docs.jabref.org/setup/citationkeypatterns" |
There was a problem hiding this comment.
same here, move it to Urls class so that there is a single class with all urls, easier for changing
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/786
Steps to test
Open JabRef > Citation key tab
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)