Skip to content

fix(#8): surface lease-release failure on forced exit and guard hydrate #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jackallink wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#8): surface lease-release failure on forced exit and guard hydrate #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/wiring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,13 @@ export function stopWithBackstop(
): void {
const hardExit = setTimeout(() => {
console.error(`[${label}] drain overran; releasing in-flight leases before forced exit`);
void Promise.race([runtime.releaseInFlightRuns(), sleep(3_000, { unref: true })]).finally(() => process.exit(0));
void Promise.race([runtime.releaseInFlightRuns(), sleep(3_000, { unref: true })]).then(
() => process.exit(0),
(e: unknown) => {
console.error(`[${label}] lease release failed: ${errMessage(e)}`);
process.exit(1);
},
);
}, shutdownDrainMs + 5_000);
hardExit.unref();
void runtime.stop().then(
Expand All @@ -295,7 +301,9 @@ export function stopWithBackstop(
(e: unknown) => {
console.error(`[${label}] graceful stop failed: ${errMessage(e)}`);
clearTimeout(hardExit);
void Promise.race([runtime.releaseInFlightRuns(), sleep(3_000, { unref: true })]).finally(() => process.exit(1));
void Promise.race([runtime.releaseInFlightRuns(), sleep(3_000, { unref: true })])
.catch(() => undefined)
.finally(() => process.exit(1));
},
);
}
Expand Down Expand Up @@ -410,7 +418,9 @@ export function buildApp(
},
});
const identity = createIdentityService(artifactMap<DeactivationRecord>("deactivated_principals"));
void identity.hydrate();
void identity.hydrate().catch((e: unknown) => {
console.error(`[wiring] identity hydrate failed: ${errMessage(e)}`);
});
const leaderLease: LeaderLease = pgArtifactMap
? createPostgresLeaderLease(pgArtifactMap.pool)
: createNoopLeaderLease();
Expand Down