Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/core/elements: Show the correct ranking #105

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

Panchajanya1999
Copy link
Contributor

Show the correct ranking

@stackblitz
Copy link

stackblitz bot commented Oct 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2023

⚠️ No Changeset found

Latest commit: 5f99e8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Panchajanya1999
Copy link
Contributor Author

@JacobLinCool can you review and merge it please?

@JacobLinCool JacobLinCool self-requested a review October 29, 2023 14:50
@JacobLinCool
Copy link
Owner

I believe the accurate ranking is not necessary for large ranks and sometimes make the displayed information too complex.

But I will still merge it and maybe add an option to use the current behavior later.

Thanks for your contribution!

@JacobLinCool JacobLinCool merged commit 9d1032d into JacobLinCool:main Oct 29, 2023
2 checks passed
@Panchajanya1999
Copy link
Contributor Author

I believe the accurate ranking is not necessary for large ranks and sometimes make the displayed information too complex.

But I will still merge it and maybe add an option to use the current behavior later.

Thanks for your contribution!

thank you for merging.
I have an idea - What about adding a comma in between the numbers?
Like - #123456 looks better when it is #123,456.

I am planning to implement it but sadly i cant start the server. Do you have a Telegram account so that we can discuss on it? My TG username is - @Panchajanya1999 on TG too.

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants