Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Updating type casting to bools #74

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(types): Updating type casting to bools #74

merged 1 commit into from
Jan 31, 2025

Conversation

Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request includes a change to the setTypeInfo method in the Column struct within the pkg/entities/column.go file. The change involves refining the logic for setting the column type based on the MySQL field type.

Improvements to type setting logic:

  • pkg/entities/column.go: Updated the setTypeInfo method to use a switch statement for more precise type assignments, specifically handling mysql.TypeTiny, mysql.TypeShort, and mysql.TypeInt24 to set the column types to "tinyint", "smallint", and "mediumint" respectively. The default case falls back to using the EvalType method.

@Jacobbrewer1 Jacobbrewer1 merged commit 21f8155 into main Jan 31, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the fix/bools branch January 31, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant