Add more explicit comparison operators for clang

Jacquwes · Sep 27, 2023 · 4525611 · 4525611
1 parent e787517
commit 4525611
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/shared/include/snowflake.h b/shared/include/snowflake.h
@@ -45,10 +45,10 @@ namespace pine
 		bool operator ==(snowflake const& other) const;
 
 		/// @brief Compare a snowflake with an id.
-		bool operator !=(uint64_t const& other) const;
+		bool operator !=(uint64_t other) const;
 
 		/// @brief Compare a snowflake with an id.
-		bool operator ==(uint64_t const& other) const;
+		bool operator ==(uint64_t other) const;
 
 		/// @brief Convert the snowflake to an id.
 		constexpr operator uint64_t() const

diff --git a/shared/src/snowflake.cpp b/shared/src/snowflake.cpp
@@ -48,12 +48,12 @@ namespace pine
 			&& value.sequence == other.value.sequence;
 	}
 
-	bool snowflake::operator !=(uint64_t const& other) const
+	bool snowflake::operator != (uint64_t other) const
 	{
-		return !(*this == other);
+		return !(static_cast<uint64_t>(*this) == other);
 	}
 
-	bool snowflake::operator ==(uint64_t const& other) const
+	bool snowflake::operator ==(uint64_t other) const
 	{
 		return static_cast<uint64_t>(*this) == other;
 	}