Conversation
Implements on-chain Space Invaders demonstrating cougr-core ECS integration with Soroban. Includes complete game logic, 13 unit tests, and CI/CD workflow. Closes salazarsebas#8
Addresses PR review feedback: - Refactored game_state.rs with EntityPosition, Velocity, and Health components - Updated lib.rs to actively use cougr-core World and Position types - Deployed contract to Stellar Testnet (CD6EUPL7Z255BTDPOCMQVWQ7CNM4ORP7QEFPPHO6JC63HRGLW6PYQAG7) - Enhanced README with professional tables and cougr-core benefits documentation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac78b1c7e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [dependencies] | ||
| cougr-core = { tag = "v0.0.1", git = "https://github.com/salazarsebas/Cougr.git" } |
There was a problem hiding this comment.
Depend on local cougr-core to avoid stale builds
The example crate pulls cougr-core from a Git tag, so cargo build/cargo test for this repo will compile the example against the remote v0.0.1 snapshot instead of the code in this checkout. That means the new workflow can pass even if the current commit breaks the example API, and it also makes offline/local builds fail. In a repo-local example, this should be a path = "../.." (or workspace) dependency so the example always validates against the code under review.
Useful? React with 👍 / 👎.
No description provided.