Fixes #7
Fixes #7
Conversation
| @@ -12,7 +12,7 @@ environment: | |||
| sdk: '>=2.0.0 <3.0.0' | |||
|
|
|||
| dependencies: | |||
| vm_service_lib: ^0.3.5 | |||
| vm_service: ^2.1.1 | |||
| watcher: ^0.9.7 | |||
| glob: ^1.1.3 | |||
There was a problem hiding this comment.
Maybe take the opportunity to upgrade to latest version (1.2.0)?
There was a problem hiding this comment.
This line above :)
glob: ^1.1.3
Line 17, where this comment is!
There was a problem hiding this comment.
My screen shows an except of 6 lines, nothing highlighting line 17 specifically - so I think maybe GitHub has a bit of a UI problem there. 😉
Anyhow, the changes I made do not in any way relate to the use of glob - the package is still compatible with the 1.1 series of this package, as no new features from the 1.2 series are required, so, no.
You should let the consumer and/or package manager decide which version they need/want - this is the problem that package managers were intended to solve. The system works. 😄
|
@renatoathaydes any chance we could get this PR merged in? I agree with @mindplay-dk to avoid bundling unrelated changes into a PR that fixes this bug. I'm currently running off the fork because Thanks for the hard work on the lib :) |
Closes #5 and #6.