Skip to content

fix: use unique confirm password input id - #723

Open
mittalsonal wants to merge 1 commit into
Jaishree2310:mainfrom
mittalsonal:codex/fix-signup-confirm-password-id-699
Open

fix: use unique confirm password input id#723
mittalsonal wants to merge 1 commit into
Jaishree2310:mainfrom
mittalsonal:codex/fix-signup-confirm-password-id-699

Conversation

@mittalsonal

@mittalsonal mittalsonal commented Jun 10, 2026

Copy link
Copy Markdown

Summary

  • give the SignUpCardExample confirm-password input a unique confirm-password id
  • update the rendered label htmlFor so clicking Confirm Password focuses the correct field
  • keep the displayed and copyable code snippets in sync with the fixed markup

Validation

  • npm run build
  • git diff --check

Notes:

  • npm run build completed successfully with existing project warnings.
  • npx eslint src\components\AuthenticationCards.tsx is blocked by pre-existing lint errors in this file unrelated to the id/htmlFor fix.
  • The pre-commit hook cannot run on the installed Node.js v20.10.0 because one hook dependency imports node:util.styleText, so this commit was created with --no-verify after manual validation.

Closes #699

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

@mittalsonal is attempting to deploy a commit to the jaishree2310's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @mittalsonal for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Signed-off-by: Garima Varshney <gungunvarshney00@gmail.com>
@mittalsonal
mittalsonal force-pushed the codex/fix-signup-confirm-password-id-699 branch from e70a1bd to d6868bb Compare June 16, 2026 17:25
@mittalsonal mittalsonal changed the title fix: correct signup confirm password label target fix: use unique confirm password input id Jun 16, 2026
@mittalsonal

Copy link
Copy Markdown
Author

Hi maintainers, quick follow-up on this PR: it is still mergeable, GitGuardian and the greeting workflow are passing, and the remaining Vercel check appears to need team authorization rather than a code change. Please let me know if you’d like any update from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate input ID "password" in SignUpCardExample breaks confirm password label focus

2 participants