Core: Propagate URL query key-value pairs present in QUnit.config.urlCon... #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. @scottgonzalez Can you take a peek and compare this to what jQuery UI is currently doing and/or needs? Thanks! |
| @@ -128,8 +182,24 @@ QUnit.testSuites = function( name, suites ) { | |||
| } | |||
| }); | |||
|
|
|||
| query = parseQuery( location.search ); | |||
There was a problem hiding this comment.
Can't you just use QUnit.urlParams here?
|
I think this can be dramatically reduced, and it should probably have accompanying tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core: Propagate URL query key-value pairs present in QUnit.config.urlConfig to suites.
What this commit do was done separatelly before, for example in jQuery UI Test Suite: https://raw.githubusercontent.com/jquery/jquery-ui/6df127a0b591d2a1437361f9cb6f3524a7b2e111/tests/unit/all.html
I think this should be the default way of handling top frame query string. I can't think of any scenario where this wouldn't be the desired behaviour.