-
Notifications
You must be signed in to change notification settings - Fork 0
To be reviewed #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanefrancessC
wants to merge
34
commits into
for-review
Choose a base branch
from
master
base: for-review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
To be reviewed #16
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
f087b30
changed the title
JanefrancessC 8e0a658
search field not displaying the filtered array yet(pickedEpisodes)
JanefrancessC 12bf9de
stopped at linking selected option to the episode
JanefrancessC 17c1ef2
stopped at linking selected option to the episode
JanefrancessC 0c6b5a1
select option done
JanefrancessC efd42f7
Merge pull request #1 from JanefrancessC/level-100
JanefrancessC c614283
100 complete
JanefrancessC b88a1c3
Merge pull request #2 from JanefrancessC/level-100
JanefrancessC 97ebaed
lvl-100 complete
JanefrancessC d7e536d
Merge pull request #3 from JanefrancessC/level-100
JanefrancessC 9910944
350 completed
JanefrancessC a10038f
Merge pull request #4 from JanefrancessC/level-100
JanefrancessC d453fca
responsive design
JanefrancessC 08b56c1
Merge pull request #5 from JanefrancessC/level-100
JanefrancessC 4dc7cb6
responsive design
JanefrancessC 5f17d89
Merge pull request #6 from JanefrancessC/level-100
JanefrancessC d88f32a
responsive design
JanefrancessC b93966e
Merge pull request #7 from JanefrancessC/level-100
JanefrancessC 0ad3389
responsive tab screen
JanefrancessC 0da89f7
Merge pull request #8 from JanefrancessC/level-100
JanefrancessC 6440ae8
responsive tab screen
JanefrancessC 67e08c6
Merge pull request #9 from JanefrancessC/level-100
JanefrancessC 08d1752
responsive tab screen
JanefrancessC b2cd437
Merge pull request #10 from JanefrancessC/level-100
JanefrancessC 947fb98
search show and select show added
JanefrancessC 0d5bdf4
Merge pull request #11 from JanefrancessC/level-100
JanefrancessC 1138f95
search show and select show designs
JanefrancessC d126e03
search show and select show designs
JanefrancessC 04ddd84
Merge pull request #12 from JanefrancessC/level-100
JanefrancessC c990fab
Merge pull request #13 from JanefrancessC/level-100
JanefrancessC ac07cd3
search functionality extended
JanefrancessC c6a87d3
Merge pull request #14 from JanefrancessC/level-100
JanefrancessC 903b905
completed level 500
JanefrancessC 0187d1d
Merge pull request #15 from JanefrancessC/level-100
JanefrancessC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "liveServer.settings.port": 5501 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| @media (max-width: 1024px) { | ||
| #container { | ||
| width: 100%; | ||
| grid-template-columns: repeat(3, 1fr); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| @media (max-width: 600px) { | ||
| .search { | ||
| background-color: rgb(9, 9, 9); | ||
| width: 100%; | ||
| height: 8rem; | ||
| flex-direction: column; | ||
| justify-content: space-around; | ||
| align-items: center; | ||
| gap: 1rem; | ||
| margin: auto; | ||
| } | ||
|
|
||
| #container { | ||
| display: grid; | ||
| grid-template-columns: 1fr; | ||
| width: 80%; | ||
| } | ||
|
|
||
| .episode-container { | ||
| width: 75%; | ||
| margin: 1.5rem 2rem; | ||
| margin-left: 3rem; | ||
| } | ||
|
|
||
| #select-reset { | ||
| margin-top: 2rem; | ||
| } | ||
|
|
||
| #input-search { | ||
| justify-content: center; | ||
| align-items: center; | ||
| gap: 0.7rem; | ||
| padding-left: 6rem; | ||
| margin-bottom: 1.5rem; | ||
| } | ||
|
|
||
| #display-count { | ||
| color: rgb(218, 33, 16); | ||
| font-weight: 700; | ||
| font-size: small; | ||
| } | ||
|
|
||
| #search-field[placeholder="🔍"] { | ||
| opacity: 0; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see media queries to make the site responsive. there is slight issue with break points as the site doesn't break immediately after hitting the element but goes on to cover it for a bit before it breaks, but its a simple fix