Skip to content

PR 도중 main에 들어온 테스트를 잠금 검사가 잘못 잡는다 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jang990 merged 1 commit into from
Sep 9, 2026
Merged

PR 도중 main에 들어온 테스트를 잠금 검사가 잘못 잡는다 #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ jobs:
# 자기가 쓰는 픽스처를 못 고쳐서 "테스트 먼저 → 구현" 순서가 성립하지 않는다.
- name: 테스트 명세 잠금
run: |
BASE=$(git merge-base origin/${{ github.base_ref }} HEAD)
FIRST=$(git rev-list ${BASE}..HEAD | tail -1)
CHANGED=$(git diff --name-only ${FIRST}..HEAD -- tests/ ':(exclude)tests/fixtures/')
# pull_request 체크아웃의 HEAD 는 브랜치 끝이 아니라 base 와 미리 합쳐본
# 머지 커밋이다. HEAD 를 끝점으로 쓰면 PR 이 열려 있는 동안 main 에 들어온
# 테스트까지 이 PR 이 고친 것으로 잡힌다.
HEAD_SHA=${{ github.event.pull_request.head.sha }}
BASE=$(git merge-base origin/${{ github.base_ref }} ${HEAD_SHA})
FIRST=$(git rev-list ${BASE}..${HEAD_SHA} | tail -1)
CHANGED=$(git diff --name-only ${FIRST}..${HEAD_SHA} -- tests/ ':(exclude)tests/fixtures/')
if [ -n "$CHANGED" ]; then
echo "::error::첫 커밋 이후 테스트가 수정됨"
echo "$CHANGED"
Expand Down
Loading