Adding the RedirectToOverrides to enable redirect_to also for remotipart submitted actions. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art submitted actions
|
👍 +1 using this successfully in production |
| include ERB::Util | ||
|
|
||
| def self.included(base) | ||
| base.class_eval do |
There was a problem hiding this comment.
I think we should use send instead of class_eval, it will make code faster.
|
@JangoSteve any chance of getting this merged? |
|
@johnnyshields I'll check this. |
|
|
||
| def redirect_to_with_remotipart *args | ||
| if remotipart_submitted? | ||
| case redirect_path = args.shift |
There was a problem hiding this comment.
This doesn't seem to handle the case of something like redirect_to @post
|
Would love to see this merged, just ran into it today -- working around it by vendoring the above file and including in |
esbanarango
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, remotipart only allows us to render partials with ajax forms having file uploads. This PR provides a class 'RedirectToOverrides' similar to existing 'RenderOverrides' that can handle 'redirect_to' in case of file uploads done via remotipart.