Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text 공통 컴포넌트 구현 #20

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Text 공통 컴포넌트 구현 #20

merged 4 commits into from
Oct 30, 2023

Conversation

dlwl98
Copy link
Member

@dlwl98 dlwl98 commented Oct 26, 2023 •
edited
Loading

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

공통 컴포넌트인 Text 컴포넌트를 구현했습니다.

👨‍💻 구현 내용 or 👍 해결 내용

feat: Text 공통 컴포넌트 구현

refactor: Text컴포넌트가 children prop을 필수로 받게 수정

refactor: Text컴포넌트가 children으로 string만 받게 수정

🎯 PR 포인트

Text 컴포넌트에 있어야 하는데 누락된 기능이 있다면 알려주세요!

📝 참고 사항

사용 예시

// elilpsis 속성은 몇번째 줄에서 말줄임표를 보여줄지
<Text size={20} weight={700} lineHeight="200%" ellipsis={2}>
  가나다라마바사 가나다라마바사 가나다라마바사 가나다라마바사
  가나다라마바사 가나다라마바사 가나다라마바사 가나다라마바사
</Text>

❓ 궁금한 점

#19 close

@dlwl98 dlwl98 added the 기능 코드의 기능이 추가되거나 바뀌었습니다. label Oct 26, 2023
@dlwl98 dlwl98 self-assigned this Oct 26, 2023
@1eecan
Copy link
Contributor

1eecan commented Oct 26, 2023

🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan self-requested a review October 26, 2023 15:45
1eecan
1eecan reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@1eecan 1eecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline css 부분에 대한 수정을 해주실 수 있을까요~

@dlwl98
Copy link
Member Author

dlwl98 commented Oct 28, 2023

inline css 부분에 대한 수정을 해주실 수 있을까요~

완료했습니다!

1g2g
1g2g approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@1g2g 1g2g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드짜느라 고생하셨습니다😊
사용하기 편리하네요! LGTM입니다👍

@dlwl98 dlwl98 merged commit 97bcf77 into dev Oct 30, 2023
@dlwl98 dlwl98 deleted the feat/#19-shared-text branch October 30, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1eecan 1eecan 1eecan left review comments

@1g2g 1g2g 1g2g approved these changes

Assignees

@dlwl98 dlwl98

Labels
기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlwl98 @1eecan @1g2g