Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

랭킹 페이지에 랭킹 모달 붙이기 #236

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

dlwl98
Copy link
Member

@dlwl98 dlwl98 commented Nov 17, 2023

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

랭킹 페이지에 랭킹 모달 붙이기

👨‍💻 구현 내용 or 👍 해결 내용

chore: 툴팁 아이콘 추가
feat: 모달 손잡이 높이를 바꿀 수 있는 기능
feat: 크루 랭킹 페이지에 랭킹 모달 붙이기

스크린샷 2023-11-17 오후 5 29 57

🎯 PR 포인트

📝 참고 사항

❓ 궁금한 점

dlwl98 and others added 3 commits November 17, 2023 17:26
- 랭킹 모달 스타일 수정
- 랭킹 모달 onClick 받게 수정

Co-authored-by: Minjae Kim <[email protected]>
@dlwl98 dlwl98 added the 기능 코드의 기능이 추가되거나 바뀌었습니다. label Nov 17, 2023
@dlwl98 dlwl98 linked an issue Nov 17, 2023 that may be closed by this pull request
@1eecan
Copy link
Contributor

1eecan commented Nov 17, 2023

🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan self-requested a review November 17, 2023 08:30
@1eecan 1eecan merged commit 3ad0c11 into dev Nov 21, 2023
@1eecan 1eecan deleted the feat/#235-ranking-page branch November 21, 2023 05:15
Copy link
Member

@1g2g 1g2g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui가 너무 예뻐요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

랭킹 페이지에 랭킹 모달 붙이기
4 participants