Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchItem 공통 컴포넌트 수정 #53

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

dlwl98
Copy link
Member

@dlwl98 dlwl98 commented Oct 30, 2023

  • Button 컴포넌트 적용
  • Avatar 컴포넌트 적용

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

MatchItem 컴포넌트에 공통 컴포넌트를 적용했습니다.

👨‍💻 구현 내용 or 👍 해결 내용

🎯 PR 포인트

📝 참고 사항

MatchItem.ManageBtn이 MatchItem.BottomBtn으로 바뀌었습니다.
또한 MatchItem.BottomBtn에 text 필수 prop이 추가되었습니다.

❓ 궁금한 점

#50 close

- Button 컴포넌트 적용
- Avatar 컴포넌트 적용
@dlwl98 dlwl98 added 기능 코드의 기능이 추가되거나 바뀌었습니다. D-0 최대한 빨리 리뷰해 주세요 labels Oct 30, 2023
@dlwl98 dlwl98 self-assigned this Oct 30, 2023
@dlwl98 dlwl98 linked an issue Oct 30, 2023 that may be closed by this pull request
@1eecan
Copy link
Contributor

1eecan commented Oct 30, 2023

🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan self-requested a review October 30, 2023 09:17
Copy link
Contributor

@1eecan 1eecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@dlwl98 dlwl98 merged commit 324805a into dev Oct 30, 2023
@dlwl98 dlwl98 deleted the feat/#50-match-item-fix branch October 30, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-0 최대한 빨리 리뷰해 주세요 기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatchItem 공통 컴포넌트 수정
2 participants