Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: #51 공통 버튼 컴포넌트 수정 #56

Merged
merged 1 commit into from
Oct 30, 2023
Merged

hotfix: #51 공통 버튼 컴포넌트 수정 #56

merged 1 commit into from
Oct 30, 2023

Conversation

imb96
Copy link
Contributor

@imb96 imb96 commented Oct 30, 2023

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

font 적용 안된 부분 수정
fontSize를 number로 받으면 rem으로 변환.

👨‍💻 구현 내용 or 👍 해결 내용

🎯 PR 포인트

📝 참고 사항

❓ 궁금한 점

#51 close

@imb96 imb96 linked an issue Oct 30, 2023 that may be closed by this pull request
버튼 공통 컴포넌트 수정 #51
Closed
@imb96 imb96 self-assigned this Oct 30, 2023
@imb96 imb96 added the 긴급 긴급한 수정사항으로 바로 리뷰해 주세요. label Oct 30, 2023
@imb96 imb96 added this to the 2차 스프린트 milestone Oct 30, 2023
@1eecan
Copy link
Contributor

1eecan commented Oct 30, 2023

🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan self-requested a review October 30, 2023 09:38
1eecan
1eecan approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@1eecan 1eecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lineHeight를 자율적으로 받을 수 있게 되었군요

@1eecan 1eecan merged commit bfe7865 into dev Oct 30, 2023
@1g2g
Copy link
Member

1g2g commented Oct 30, 2023

LGTM👍👍🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1eecan 1eecan 1eecan approved these changes

Assignees

@imb96 imb96

Labels
긴급 긴급한 수정사항으로 바로 리뷰해 주세요.
Projects
None yet
Milestone
2차 스프린트
Development

Successfully merging this pull request may close these issues.

버튼 공통 컴포넌트 수정
3 participants
@imb96 @1eecan @1g2g