Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

모델 타입 정의 #68

Merged
merged 4 commits into from
Oct 31, 2023
Merged

모델 타입 정의 #68

merged 4 commits into from
Oct 31, 2023

Conversation

1g2g
Copy link
Member

@1g2g 1g2g commented Oct 31, 2023 •
edited
Loading

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

feat: 모델 타입 정의

👨‍💻 구현 내용 or 👍 해결 내용

반환 객체(DTO) 정의에 따라 모델 객체 타입을 정의했습니다.

🎯 PR 포인트

📝 참고 사항

❓ 궁금한 점

#63 close

@1g2g 1g2g added 기능 코드의 기능이 추가되거나 바뀌었습니다. D-0 최대한 빨리 리뷰해 주세요 labels Oct 31, 2023
@1g2g 1g2g added this to the 2차 스프린트 milestone Oct 31, 2023
@1g2g 1g2g assigned imb96 and 1g2g Oct 31, 2023
@1g2g 1g2g linked an issue Oct 31, 2023 that may be closed by this pull request
모델 타입 정의 #64
Closed
@1g2g 1g2g changed the title feat: 모델 타입 정의 모델 타입 정의 Oct 31, 2023
@1eecan
Copy link
Contributor

1eecan commented Oct 31, 2023

🎉 @dlwl98 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan requested a review from dlwl98 October 31, 2023 08:28
1eecan
1eecan approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@1eecan 1eecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM이네요~

@1g2g 1g2g merged commit cdbf826 into dev Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1eecan 1eecan 1eecan approved these changes

@dlwl98 dlwl98 dlwl98 approved these changes

Assignees

@imb96 imb96

@1g2g 1g2g

Labels
D-0 최대한 빨리 리뷰해 주세요 기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Milestone
2차 스프린트
Development

Successfully merging this pull request may close these issues.

모델 타입 정의
4 participants
@1g2g @1eecan @dlwl98 @imb96