-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
메인 페이지 구현 #70
Merged
Merged
메인 페이지 구현 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 임시 데이터를 사용
* 헤더,navbar max-width 삭제 * 헤더 title 위치 중간으로 수정 * 헤더 우측 아이콘 styledComponent 통일
* 글로벌스타일 변경 * 헤더 로고 변경 * 헤더 타이틀 일립시스
Closed
🎉 @dlwl98 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏 |
dlwl98
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100dvh 막 넣어도 상관없지 않을까요?
LGTM 입니다~
1g2g
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
메인페이지 구현했습니다.
👨💻 구현 내용 or 👍 해결 내용
feat: 메인페이지 구현
fix: layout 적용
🎯 PR 포인트
📝 참고 사항
❓ 궁금한 점
#44 close