Docker builds #66
Merged
Docker builds #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, \n were missing at the end of printf.
It was done in a semi-automated way. Hopefully, no more of them would ever sneak back in again.
This adds docker support for the project. Docker builds include CPU-only version, as well as different tags for some NVIDIA compute capability versions. Deploy scripts are provided, image name and used versions of both CUDA SDK and CCAP are customizable via env. Added make argument: upper-cased `CAPP` which accepts version in dotted notation (e.g. "5.2"); lower-cased `capp` is derived from it, but should still be directly overridable as any other make's variable. Instructions in README are updated accordingly. Linux section got reformatted and reworked and overall became more comprehensible (IMHO). Adding CI and automatic builds are left as an exercise for curious readers.
Closed
|
Anyone? Maintainers? @JeanLucPons Bump. |
|
Hi, |
|
Good news from docker community. Device requests were added to docker-py (docker/docker-py#2471), so just in few weeks we can expect docker-compose to support |
|
Great 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was asking for docker image, and I ended up spending a day doing it on my own. It was generally a positive deployment experience, I sure learned a thing or two in the process, and I hope it would come up handy for some.
Here is a link to Docker Hub: https://hub.docker.com/r/ratijas/vanitysearch.
Regarding this PR
I'm not certain I've done things in the best way possible, but at least I tried doing it by books.
I wasn't able to run GPU version other than my native CCAP
5.2:2.0is too old, and6.0is not supported by my hardware. But is compiles and executes (as far as giving help or an error message) just fine, so should work. Just for the hell of it, I also built5.0, and it worked as smooth as5.2. I'd be glad to hear feedback from someone for whom it works on older/newer hardware.Not sure whether we need those aliased tags, e.g.
cuda-ccap-5➡cuda-ccap-5.2. Does it make any sense, since it is not a software versioning and can't be just "updated"?The
latesttag probably not very useful either. But I kept it for the sake of conforming with docker hub conventions.As stated is the commit message, CI and automated builds are not implemented. This is because I lack experience in this field. Suggestions and pull requests and more than welcome.
To be merged after #64 and #65.
Resolves #63.