Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .npmignore to avoid path conflicts #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcofugaro
Copy link

I tried using this package with create-react-app and it breaks the webpack compilation because it has issues with the CaseSensitivePathsPlugin

here is the issue:

[CaseSensitivePathsPlugin] 
Module not found:
`/Users/marco/Code/repo/node_modules/react-codemirror/src/codemirror.js`
does not match the corresponding path on disk `Codemirror.js`.

this issue does not happen if in the package is not present a src/Codemirror.js

This should also solve issue #108

@@ -0,0 +1 @@
src/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better to use files field in package.json and explicitly specify files you want to publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants