Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass through style #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pass through style #133

wants to merge 1 commit into from

Conversation

yocontra
Copy link

components should pass through their style properties so they can be used with higher order components like react-dimensions, or just doing custom styling.

components should pass through their style properties so they can be used with higher order components like react-dimensions, or just doing custom styling.
@scniro
Copy link

scniro commented Feb 18, 2018

@contra This library is pretty much abandoned. Have you've glimpsed at the plethora of issues? I wrote react-codemirror2 and have been actively maintaining it because of the frustrations I've encountered here. Not to mention the lack of tests, heavy dependencies, ancient documentation, etc. I am shocked people are still grasping on to this library...

@yocontra
Copy link
Author

@scniro Yep - saw it, used it. Ended up switching to react-ace because getting codemirror to respond to different size constraints sucks.

Unrelated to this ticket, it would be cool if react-codemirror2 solved the responsiveness issue - width: 100% height: 100% is nearly impossible to get working, especially with flexbox in the mix.

@scniro
Copy link

scniro commented Feb 19, 2018

@contra Hm super interesting, I definitely overlook that. I opened up an issue to track it. If you can, could you please share a little more detail over there? I definitely want to fix this, and a rock solid use case would be great to work off of. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants