Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Recording Date Serialization Test #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

spottedmahn
Copy link

No description provided.

@spottedmahn spottedmahn changed the title Fix Recording Date Serialization Fix Recording Date Serialization Test Dec 3, 2019
@JeevanJames
Copy link
Owner

I believe this change does not comply with the ID3 v2.3 spec.

Per the spec, the recording date (TDAT frame) should be in the format DDMM. This frame is complimented by the TYER and TIME frames for the recording year and time.

The only other recording date frame is the TRDA frame (recording dates), but that is a free text frame, so does not need format validation.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

@spottedmahn
Copy link
Author

I believe this change does not comply with the ID3 v2.3 spec.

Oh, interesting.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

This test was failing:

public void Serialize_deserialize_test()

@spottedmahn
Copy link
Author

image

line 69: Assert.Equal(tag.RecordingDate.Value, clonedTag.RecordingDate.Value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants