forked from vmware-tanzu/tanzu-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
change antreaConfig APIversion back to v1alpha1 (vmware-tanzu#4579)
The behavior in v1alpha2 is an additive change, not the kind that would necessitate a new API version, the only difference now is that the controller needs to look at the context it’s deploying into: if the Antrea version is sufficient and it’s being deployed in an NSX context, then it can automatically create an NSXServiceAccount. Alternatively, if it needs to be optional even in that context, then it’s just an additional optional field being added to v1alpha1 with validations that ensure it’s only honored in the appropriate context. Even with a v1alpha2, we don’t want to have branching behaviors based on a storage version. With a conversion webhook, the storage version will eventually be changed to v1alpha2 the next time the resource is written, meaning the controller and API version need a way to preserve compatibility with older v1alpha1-originating configurations. So either — or both — of these options need to be undertaken even if we were to produce a v1alpha2. It might be a better option to revert the API change and preserve/augment the controller changes. Otherwise we’re adding extra conversion webhook overhead without benefit. Signed-off-by: Bin Liu <[email protected]>
- Loading branch information
Showing
31 changed files
with
256 additions
and
1,574 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.