Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested array wildcard deletion #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlourenc
Copy link

This PR supersedes #95 by supporting wildcard deletes at all levels in a Container's hierarchy.

searchStrict has been refactored and renamed into searchPaths to provide return parameters that are both useful for Search and Delete methods.

The notion of path with its associated types path and paths has been introduced to reflect the multiplicity of paths that wildcards introduce.

@jlourenc
Copy link
Author

jlourenc commented Nov 4, 2021

Hey @Jeffail, it'd be great to have your thoughts on this PR. Thanks!

@Jeffail
Copy link
Owner

Jeffail commented Nov 5, 2021

Hey @jlourenc, I'll need to put some proper time aside to understand fully what's going on here but we'd also need to leave Search unchanged, as this change would add unused allocations to a potentially hot path.

@jlourenc
Copy link
Author

jlourenc commented Nov 5, 2021

Sure @Jeffail , that makes sense. Let me revisit this PR not to impact the path of Search.

In the meantime, I've opened #115 to make Search faster when using wildcards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants