Bugfixes for EICrecon #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwbrei
force-pushed
the
nbrei_bugfixes
branch
4 times, most recently
from
d7835a9 to
65cdf5e
Compare
nathanwbrei
force-pushed
the
nbrei_bugfixes
branch
from
65cdf5e to
dc618c8
Compare
nathanwbrei
force-pushed
the
nbrei_bugfixes
branch
from
dc618c8 to
03fc16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running EICrecon against JANA2 v2.4.3 exposed some problems:
Input<T>inadvertently lost any databundle name specified via theJOmniFactoryGenerator, due to confusion about databundle name vs tagOutput<T>was not clearing the transient data container beforeJOmniFactory::Process()is calledOutput<T>caused a double-free because it wasn't passing along theNOT_OBJECT_OWNERflagJOmniFactoryGeneratorbroke compatibility with EICrecon's version, making a future migration much harder