Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chameleon, a tool for language binding generation #250

Merged
merged 41 commits into from
Jul 31, 2024
Merged

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jul 13, 2024

This introduces chameleon, a tool to automate generation of bindings and action function tests. For a proof of concept, this PR generates the C bindings for Fortran.

@c-dilks c-dilks linked an issue Jul 13, 2024 that may be closed by this pull request
@c-dilks c-dilks changed the title feat: generate Fortran bindings automatically feat: chameleon, a tool for language binding generation Jul 18, 2024
@c-dilks c-dilks marked this pull request as ready for review July 22, 2024 21:41
Copy link
Contributor

@rtysonCLAS12 rtysonCLAS12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I took so long to review, I forgot about this!
I checked the Action.yaml files, they have the right entries for each action function.

Should the ExampleAlgorithm have an Action.yaml file? This could point to the action function Filter , I think it would be helpful to refer to when writing algorithms.

@c-dilks
Copy link
Member Author

c-dilks commented Jul 26, 2024

Should the ExampleAlgorithm have an Action.yaml file? This could point to the action function Filter , I think it would be helpful to refer to when writing algorithms.

Yes, but I'm actually considering removing ExampleAlgorithm with #141, in favor of choosing three representative algorithms (a filter, a transformer, and a creator) that would serve as good examples, and moving the descriptive comments to those. Then I'll add links to those in the documentation.

rtysonCLAS12
rtysonCLAS12 previously approved these changes Jul 29, 2024
Copy link
Contributor

@rtysonCLAS12 rtysonCLAS12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sounds good

@c-dilks c-dilks merged commit a2c68c5 into main Jul 31, 2024
37 of 38 checks passed
@c-dilks c-dilks deleted the chameleon branch July 31, 2024 20:33
@c-dilks c-dilks linked an issue Aug 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cppyy: unable to unpack std::tuple with ROOT 6.32 add Fortran bindings for all the action functions
2 participants