Skip to content

feat: support for clas12root clas12reader #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

feat: support for clas12root clas12reader #364

wants to merge 16 commits into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Aug 31, 2025 •
edited
Loading

  • Algorithm::Run functions have changed
    • new algorithm-specific Run functions, which operate on lvalue references to banks
      • compatible with clas12reader's hipo::bank-derived objects
      • compatible with anyone that doesn't use hipo::banklist
    • all Run functions now return bool, providing an event-level filter, closing event-level filtering #352
      • users do not have to use the return value, so this shouldn't be a breaking change for anyone
  • used by feat: support iguana::Algorithm::Run calls clas12root#101

@github-project-automation github-project-automation bot moved this to Unsorted in Iguana Aug 31, 2025
@c-dilks c-dilks mentioned this pull request Aug 31, 2025
Draft
@c-dilks
feat: support for clas12root clas12reader
f260e68 
- new `Algorithm::CreateBank` to _just_ create a new Iguana bank, to be
  owned by the caller
- algorithm-specific `Run` functions, which operate on lvalue references
  to banks (compatible with `clas12reader`s raw pointers to
  `hipo::bank`-derived objects)
@c-dilks c-dilks linked an issue Sep 11, 2025 that may be closed by this pull request
event-level filtering #352
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtysonCLAS12 rtysonCLAS12 Awaiting requested review from rtysonCLAS12 rtysonCLAS12 will be requested when the pull request is marked ready for review rtysonCLAS12 is a code owner

@Gregtom3 Gregtom3 Awaiting requested review from Gregtom3 Gregtom3 will be requested when the pull request is marked ready for review Gregtom3 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Iguana
Status: Unsorted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event-level filtering
1 participant
@c-dilks