Adding AHDC geom in mon12 #66

ftouchte · 2024-12-17T12:46:49Z

Hello,

I have tried to produce plots with respect to the AHDC geometry on mon12.

The geometry information is retrieved from coatjava. In two temporary tabs (geomand geom_bis), I have presented some examples of use. The code is not perfect and has a lot unnecessary screen outputs. Thanks to this discussion, we can improve the result.

The following graph, in geom, shows a XY graph of the detector (2D view at the center of the detector).

The following graphs, in geom_bis, are 2D histograms showing the wire occupancy during respectively 100000 and 100 events.

100000 events

100 events

raffaelladevita · 2024-12-17T17:58:08Z

if I understood correctly, the graph would show hits for single events, right? mon12 is not really meant for that because it is usually run in accumulation mode, while CED will provide that functionality.

The 2D histogram is a better option in my opinion. A few suggestions on that:

currently, the histogram has a very large number of bins which based on previous experience, will make the histogram visualization very slow;
the number of bins could be largely reduced by changing the histogram to be for example wire layer versus wire phi. The number of bins in phi could be set to few hundreds and the bin to be filled could be chosen based on the phi range of the wire, throwing a random number to select the bin within the range. The advantage is also that the histogram would be filled continuously, which makes the occupancy patterns more easily visible.

ftouchte · 2024-12-18T12:55:36Z

Hello,

I have removed the XY graph as it was not convenient for mon12.

Concerning the 2D histogram, my intention to represent wires as filled circles led me to use a big number of bins : 1000x1000. Unfortunately, this big number of bins had a bad effect on the performance of the software.

Before continuing to your suggestion, I have renounced to the idea of representing wires as a filled circles. Now, representing a wire as a simple rectangle allowed me to reduced the number of bins up to 120x120 (a good compromise).

What do you think about this modification ?

120x120 bins

100x100 bins

80x80 bins

36x36 bins

Renounce to the idea of representing wires as filled circles

raffaelladevita · 2024-12-19T00:47:14Z

Hi, Thanks for addressing my comments so quickly. 120x120 bin should definitely be manageable. The one concern that I would still have is about how easy it would be for shift takers to spot a missing wire…in my experience, a histogram where all bins are by default filled makes it easier, hence my suggestion on phi vs. layer

…

On 18 Dec 2024, at 13:55, Felix Touchte Codjo ***@***.***> wrote: Hello, I have removed the XY graph as it was not convenient for mon12. Concerning the 2D histogram, my intention to represent wires as filled circles lead me to use a big number of bins : 1000x1000. Unfortunately, this big number of bins had a bad effect on the performance of the software. Before continuing to your suggestion, I have renounced to the idea of representing wires as a filled circles. Now, representing a wire as a simple rectangle allowed me to reduced the number of bins up to 120x120 (a good compromise). What do you think about this modification ? 120x120 bins 120bins.png (view on web) <https://github.com/user-attachments/assets/2ad0b15c-4e16-4504-9135-2e2b606e5fb5> 100x100 bins 100bins.png (view on web) <https://github.com/user-attachments/assets/a6bc1dec-2522-4a06-89c9-a14675eda1d8> 80x80 bins 80bins.png (view on web) <https://github.com/user-attachments/assets/6ec312b3-7776-4a8c-8311-b97892dea782> 36x36 bins 36bins.png (view on web) <https://github.com/user-attachments/assets/cafe86fd-ed22-42d0-b40c-f417db6f09ed> — Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZNEPWD35VELY4NOUVOYDT2GFWF7AVCNFSM6AAAAABTYLCIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRGI2TIOBYGQ>. You are receiving this because you commented.

ftouchte · 2025-01-08T12:36:43Z

Hi,

Sorry for the delay. It's true, it's difficult to have access to a given wire in the "x vs y" representation. But, as we don't have the same number of wires in each layer, using "phi vs layer" will be also difficult.

Here is an alternative : wire vs layer

layer ID	layer number
11	1
21	2
22	3
31	4
32	5
41	6
42	7
51	8

What do you think ?

Another question : I know there is a new branch with the new version of coatjava that implements the AHDC decoder. I wonder how to use this decoder in coatjava.

raffaelladevita · 2025-01-08T22:46:30Z

Hi Felix, That seems a good solution. To switch to the new decode, it should be sufficient to change the coat-libs version in the mon12 pom file https://github.com/JeffersonLab/mon12/blob/main/pom.xml#L12 to the latest release number, i.e. 11.1.0. On Jan 8, 2025, at 7:37 AM, Felix Touchte Codjo ***@***.***> wrote: Hi, Sorry for the delay. It's true, it's difficult to have access to a given wire in the "x vs y" representation. But, as we don't have the same number of wires in each layer, using "phi vs layer" will be also difficult. Here is an alternative : wire vs layer layer ID layer number 11 1 21 2 22 3 31 4 32 5 41 6 42 7 51 8 What do you think ? Another question : I know there is a new branch with the new version of coatjava that implements the AHDC decoder. I wonder how to use this decoder in coatjava. Capture.d.ecran.de.2025-01-08.12-40-10.png (view on web)<https://github.com/user-attachments/assets/c9e81f13-654e-4e3f-92c8-2a0d8f0955cc> — Reply to this email directly, view it on GitHub<#66 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABZNEPUJWFCLFTIFKGQ4QQL2JULXDAVCNFSM6AAAAABTYLCIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXGU3TEMRVGY>. You are receiving this because you commented.Message ID: ***@***.***>

Backup : need to fix maven dependencies

baltzell · 2025-01-17T16:11:47Z

here's the needed fix for coatjava: JeffersonLab/coatjava#432

ftouchte · 2025-01-27T15:40:28Z

Hi everyone,

I have made some modification in coatjava JeffersonLab/coatjava#446 to recover more data from AHDC pulse analysis.

I have re-organised the AHDC tab in mon12 to show :

charge
- occupancy
- average of adcMax
- average of integral
time
- average of timeMax
- average of leadingEdgeTime
- average of timeOverThreshold
- average of constantFractionTime

Here is the result when reading some evio files.

Here is the result when reading some hipo files containing the relevant data.

Comment

My remaining concern is the way I have computed the mean values of the decoded quantity. Is it the good way to do that?

Also, what plots should be displayed in ALERT part of the Summary tab ?

raffaelladevita · 2025-02-03T16:16:22Z

The new tabs look very good to me. Concerning your questions:

one alternative way to calculate averages is to fill in processEvent a histogram with the quantity to average as a weight, e.g. this.getDataGroup().getItem(0,0,0).getH2F("integral").fill(comp, layer_number, integral), and a histogram with just the number of entries, e.g. this.getDataGroup().getItem(0,0,0).getH2F("raw").fill(comp, layer_number), and then divide the first by the second in the analysisUpdate method.
I would display the occupancy in the summary tab.

ftouchte · 2025-02-04T15:50:57Z

Thank you very much, I will update the code.

ftouchte · 2025-02-06T22:50:09Z

Hi,

I have displayed the occupancy in the summary tab.

Concerning the analysisUpdate() method, I wonder when and how many time it is called because if

$$\overline{x}_{N} = \frac{1}{N} \sum_{k=1}^N {x_k}$$

and

$$\overline{x}_{N+1} = \frac{1}{N+1} \sum_{k=1}^{N+1}{x_k} = \frac{1}{N+1} \left( N \overline{x}_{N} + x_{N+1} \right)$$

and this method is used more that one time, I think we could accumulate error :

$$\overline{x}_{N+1} \neq \frac{\overline{x}_{N} + x_{N+1}}{N+1}$$

Am I right ?

raffaelladevita · 2025-02-06T23:39:39Z

You are right: doing it like that would introduce a bias.

In suggesting this approach, I forgot to mention something important...
You will need two histograms for each quantity you want to compute the average of: one that you should keep filling with the weight equal to the quantity to average, and a second one that will be filled in analysisUpdate with. the ratio of the first histogram and the raw occupancy.
Referring to the example above, in processEvent, you would have:

          this.getDataGroup().getItem(0,0,0).getH2F("raw_integral").fill(comp, layer_number, integral);
          this.getDataGroup().getItem(0,0,0).getH2F("raw").fill(comp, layer_number);

and in analysisUpdate

         H2F h1 = this.getDataGroup().getItem(0,0,0).getH2F("integral");
         H2F h2 = this.getDataGroup().getItem(0,0,0).getH2F("raw_integral");
         H2F h3 = this.getDataGroup().getItem(0,0,0).getH2F("raw");
        for(int ibin=0; ibin<h1.getDataBufferSize(); ibin++) {
            float b2 = h.2getDataBufferBin(ibin);
            float b3 = h3.getDataBufferBin(ibin);
            if(b3>0)
                h1.setDataBufferBin(ibin, b2/b2);
        }

ftouchte · 2025-02-07T14:46:47Z

I have finally used the analysisUpdate() method to compute the averages of each decoding outputs.

Everything works fine with hipo files. For evio files, as we need to use the decoder, I had to store more data in the AHDC::adc bank. So I have done some modifications in coatjava.

JeffersonLab/coatjava/pull/446

whit2333 · 2025-02-09T04:57:45Z

@raffaelladevita could you please review/merge?

raffaelladevita · 2025-02-09T18:11:55Z

It cannot be merged yet because it requires a new version of coatjava with updates to the decoder and AHDC::add bank

…

On 8 Feb 2025, at 23:58, Whitney Armstrong ***@***.***> wrote: @raffaelladevita <https://github.com/raffaelladevita> could you please review/merge? — Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZNEPQGBXWSUFWJGOQ4W7T2O3N55AVCNFSM6AAAAABTYLCIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGA3DSOJRHA>. You are receiving this because you were mentioned.

whit2333 · 2025-02-09T21:56:10Z

@ftouchte What is the status of the decoder (evio)? I assume this (JeffersonLab/coatjava#446) is the PR that has those changes?

Merge branch 'main' of https://github.com/JeffersonLab/mon12 into issue/sync-fork

whit2333 · 2025-02-15T04:44:50Z

@ftouchte could you please rebase the PR?

ftouchte · 2025-02-17T11:04:05Z

@whit2333 I think my PR is already up to date with the recent changes in mon12.

whit2333 · 2025-02-20T19:14:36Z

I just checked on clondaq7 with a recent run and I get this repeated error

[bank] Error (PUT) :: ( AHDC::adc) the entry id has type Short while requested UNDEFINED

@baltzell or @raffaelladevita do you know what line is causing this error to print?

ftouchte · 2025-02-20T19:35:45Z

I just checked on clondaq7 with a recent run and I get this repeated error
[bank] Error (PUT) :: ( AHDC::adc) the entry id has type Short while requested UNDEFINED

@whit2333
This can occur when

the CLAS12DIR environment variable does not indicate the good caotjava repository
when using mvn install, the coatjava package is usually re-downloaded from the maven repository. So that can overwrite the local coatjava
there is also the version comptability. When building the development coatjava, it will create a package with the version 11.1.2-SNAPSHOT, while mon12 currently requires the version 11.1.0-SNAPSHOT.

To deal with that, I have just rename the package name and overwrite the coatjava downloaded by maven (/home/username/.m2/repository/org/jlab/coat/coat-libs).

whit2333 · 2025-02-20T21:48:13Z

@ftouchte , you are right I needed to update my coatjava version. The errors remain and the histograms are still not being populated.
Can you check with a recent run (https://userweb.jlab.org/~whit/data_files/CI_tests/alert_020771.evio.00000)?

ftouchte · 2025-02-21T11:02:02Z

@whit2333
Yes, here is the result.

Terminal output (mon12_output.txt )

Plot

Here are the steps I have followed :

#mvn clean

ifarm2401.jlab.org> mvn install
Failed to load native library:jansi-2.4.1-c408528079fcc0ac-libjansi.so. The native library file at /tmp/jansi-2.4.1-c408528079fcc0ac-libjansi.so is not executable, make sure that the directory is mounted on a partition without the noexec flag, or set the jansi.tmpdir system property to point to a proper location.  osinfo: Linux/x86_64
java.lang.UnsatisfiedLinkError: /tmp/jansi-2.4.1-c408528079fcc0ac-libjansi.so: /tmp/jansi-2.4.1-c408528079fcc0ac-libjansi.so: failed to map segment from shared object
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< org.clas.detector:clas12mon >---------------------
[INFO] Building clas12mon 7.10
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from clas12maven: https://clasweb.jlab.org/clas12maven/org/jlab/coat/coat-libs/11.1.0-SNAPSHOT/maven-metadata.xml
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ clas12mon ---
...

ifarm2401.jlab.org> echo $CLAS12DIR
/u/scigroup/cvmfs/hallb/clas12/sw/noarch/coatjava/11.1.1
ifarm2401.jlab.org> setenv CLAS12DIR /w/hallb-scshelf2102/clas12/users/touchte/coatjava/coatjava
ifarm2401.jlab.org> echo $CLAS12DIR
/w/hallb-scshelf2102/clas12/users/touchte/coatjava/coatjava

ifarm2401.jlab.org> ls -ll /home/touchte/.m2/repository/org/jlab/coat/coat-libs/11.1.0-SNAPSHOT/
total 259230
-rw-r--r--. 1 touchte clas12-grp 198289518 Feb 12 10:50 coat-libs-11.1.0-SNAPSHOT.jar
-rw-r--r--. 1 touchte enp              477 Jan  2 17:37 coat-libs-11.1.0-SNAPSHOT.pom
-rw-r--r--. 1 touchte enp              226 Feb  6 16:27 _remote.repositories
-rw-r--r--. 1 touchte enp              235 Feb 21 05:12 resolver-status.properties
ifarm2401.jlab.org> 
ifarm2401.jlab.org> cp /w/hallb-scshelf2102/clas12/users/touchte/coatjava/coatjava/lib/clas/coat-libs-11.1.2-SNAPSHOT.jar /home/touchte/.m2/repository/org/jlab/coat/coat-libs/11.1.0-SNAPSHOT/coat-libs-11.1.0-SNAPSHOT.jar 
ifarm2401.jlab.org> ls -ll /home/touchte/.m2/repository/org/jlab/coat/coat-libs/11.1.0-SNAPSHOT/
total 259278
-rw-r--r--. 1 touchte clas12-grp 198298382 Feb 21 05:21 coat-libs-11.1.0-SNAPSHOT.jar
-rw-r--r--. 1 touchte enp              477 Jan  2 17:37 coat-libs-11.1.0-SNAPSHOT.pom
-rw-r--r--. 1 touchte enp              226 Feb  6 16:27 _remote.repositories
-rw-r--r--. 1 touchte enp              235 Feb 21 05:12 resolver-status.properties
ifarm2401.jlab.org> 
ifarm2401.jlab.org> 
ifarm2401.jlab.org>

ifarm2401.jlab.org> ./bin/mo
mon12*       mon12_hydra* mon12_rgc*   mon12_rgd*   mon12_rge*   mon12_rgk*   mon12-rgl*   mon12_rgm*   
ifarm2401.jlab.org> ./bin/mon12
[HipoDataSync] ---> dictionary size = 241
[ConstantsManager] --->  loading table for run = 2284
[DB] --->  open connection with : mysql://[email protected]/clas12
[DB] --->  database variation   : default
[DB] --->  database run number  : 2,284
[DB] --->  database time stamp  : 2/21/25, 5:25 AM
[DB] --->  database connection  : success
***** >>> adding :      BMTconfig / table = /daq/config/bmt
[DB] --->  database disconnect  : success
[RCDB] --->  open connection with : mysql://[email protected]/rcdb
[RCDB] --->  database connection  : success
[RCDB] --->  database disconnect  : success
...
#see file mon12_output.txt

Remark, this figure shows another issue related to the slco indexing in the AHDC::adc bank. Indeed, if you look at a decoded file, for example /w/hallb-scshelf2102/clas12/users/touchte/alert_020771.evio.00000.hipo , you will notice that all the hits of the AHDC::adc bank have the same sector, layer, component, order identifiers while the AHDC::wf bank has more realistic slco identifiers. I suspect there is a issue when copying the sloc index of the AHDC::wf bank to the AHDC::adc bank

https://github.com/JeffersonLab/coatjava/blob/e4ba622ad161e9f1fc55478f5c1b0e09a3656c65/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java#L274
or
https://github.com/JeffersonLab/coatjava/blob/e4ba622ad161e9f1fc55478f5c1b0e09a3656c65/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java#L296

copyIndices() is a method defined in HipoExtractor.

raffaelladevita · 2025-02-21T18:36:21Z

see JeffersonLab/coatjava#483
When this will be resolved, a new coatjava release can be tagged and used for building mon12

ftouchte · 2025-02-21T18:53:22Z

I think, I just understand what is going wrong. It is in ModeAHDC, I never fill the id attribute of a pulse in the extract method. I will fix this issue, do some test on evio files and create a new pull request in coatjava. Thanks for noticing @raffaelladevita !

ftouchte · 2025-02-23T11:42:16Z

I have fixed the issue. JeffersonLab/coatjava#480

baltzell · 2025-02-27T16:33:37Z

can this be merged?

Felix Touchte Codjo added 2 commits December 13, 2024 12:13

print all AHDC wires in a new tab call geom

2a37d4c

Succeed to plot occupancy with AHDC geometry

0cc96d5

Reduce the number of bins in AHDC 2D hists

3915ded

Renounce to the idea of representing wires as filled circles

Plot hits using wire vs layer

d33c824

Felix Touchte Codjo added 2 commits January 15, 2025 11:22

Add histograms of data extracted from the AHDC wf

cb3e5d0

Test AHDC in mon12 with a local version of coatjava

9125f75

Backup : need to fix maven dependencies

Compute mean values related to AHDC pulse analysis

6b60736

Change the view of the Summary/ALERT/AHDC tab

4e72b13

Felix Touchte Codjo added 2 commits February 7, 2025 05:20

Compute mean values using analysisUpdate() method

50f1cb1

make as before

fa87d12

ftouchte linked an issue Feb 10, 2025 that may be closed by this pull request

Submit mon12 modification for AHDC ftouchte/mon12#1

Open

Sync my fork with the offical repo

975e045

Merge branch 'main' of https://github.com/JeffersonLab/mon12 into issue/sync-fork

baltzell requested a review from raffaelladevita February 20, 2025 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding AHDC geom in mon12 #66

Adding AHDC geom in mon12 #66

ftouchte commented Dec 17, 2024

raffaelladevita commented Dec 17, 2024

ftouchte commented Dec 18, 2024 •

edited

Loading

raffaelladevita commented Dec 19, 2024 via email

ftouchte commented Jan 8, 2025

raffaelladevita commented Jan 8, 2025 via email

baltzell commented Jan 17, 2025

ftouchte commented Jan 27, 2025

raffaelladevita commented Feb 3, 2025

ftouchte commented Feb 4, 2025

ftouchte commented Feb 6, 2025

raffaelladevita commented Feb 6, 2025

ftouchte commented Feb 7, 2025

whit2333 commented Feb 9, 2025

raffaelladevita commented Feb 9, 2025 via email

whit2333 commented Feb 9, 2025 •

edited

Loading

whit2333 commented Feb 15, 2025

ftouchte commented Feb 17, 2025 •

edited

Loading

whit2333 commented Feb 20, 2025 •

edited

Loading

ftouchte commented Feb 20, 2025 •

edited

Loading

whit2333 commented Feb 20, 2025 •

edited

Loading

ftouchte commented Feb 21, 2025

raffaelladevita commented Feb 21, 2025

ftouchte commented Feb 21, 2025 •

edited

Loading

ftouchte commented Feb 23, 2025

baltzell commented Feb 27, 2025

Adding AHDC geom in mon12 #66

Are you sure you want to change the base?

Adding AHDC geom in mon12 #66

Conversation

ftouchte commented Dec 17, 2024

raffaelladevita commented Dec 17, 2024

ftouchte commented Dec 18, 2024 • edited Loading

raffaelladevita commented Dec 19, 2024 via email

ftouchte commented Jan 8, 2025

raffaelladevita commented Jan 8, 2025 via email

baltzell commented Jan 17, 2025

ftouchte commented Jan 27, 2025

raffaelladevita commented Feb 3, 2025

ftouchte commented Feb 4, 2025

ftouchte commented Feb 6, 2025

raffaelladevita commented Feb 6, 2025

ftouchte commented Feb 7, 2025

whit2333 commented Feb 9, 2025

raffaelladevita commented Feb 9, 2025 via email

whit2333 commented Feb 9, 2025 • edited Loading

whit2333 commented Feb 15, 2025

ftouchte commented Feb 17, 2025 • edited Loading

whit2333 commented Feb 20, 2025 • edited Loading

ftouchte commented Feb 20, 2025 • edited Loading

whit2333 commented Feb 20, 2025 • edited Loading

ftouchte commented Feb 21, 2025

raffaelladevita commented Feb 21, 2025

ftouchte commented Feb 21, 2025 • edited Loading

ftouchte commented Feb 23, 2025

baltzell commented Feb 27, 2025

ftouchte commented Dec 18, 2024 •

edited

Loading

whit2333 commented Feb 9, 2025 •

edited

Loading

ftouchte commented Feb 17, 2025 •

edited

Loading

whit2333 commented Feb 20, 2025 •

edited

Loading

ftouchte commented Feb 20, 2025 •

edited

Loading

whit2333 commented Feb 20, 2025 •

edited

Loading

ftouchte commented Feb 21, 2025 •

edited

Loading